Closed Bug 1740297 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 31561 - [FlexNG] Fragmentation for stretched items

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31561 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31561
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Fragmentation for stretched items

As suggested in CL:3256656, refactor ApplyStretchAlignmentToChild()
to use BuildSpaceForLayout. To accomplish this, pass the final line
cross size into BuildSpaceForLayout during the final layout pass for
stretched items.

By doing this we can remove ApplyStretchAlignmentToChild(), and call
into LayoutWithBlockFragmentation() for stretched items if applicable
(since that will also call into BuildSpaceForLayout).

A new wpt test was added to test basic fragmentation for stretched flex
items.

virtual/layout_ng_flex_frag/fast/multicol/flexbox/doubly-nested-with-zero-width-flexbox-and-forced-break-crash.html
is now being skipped due to a timeout. Seems to be caused by the
forced break. This test was not timing out before since the
test was previously falling back to legacy. This will be
investigated in a follow-up.

Bug: 660611
Change-Id: Ifefbe1480c7134c5fbf215cd1e03a8e79e45f1ff

Reviewed-on: https://chromium-review.googlesource.com/3267938
WPT-Export-Revision: b7dc79ceb7fc6d801432e82be153ec0ee5325f47

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cd5ea214a1e
[wpt PR 31561] - [FlexNG] Fragmentation for stretched items, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7cd5ea214a1e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.