Closed Bug 1740302 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31562 - Fix flakiness of wpt/web-animations/.../onfinish.html

Categories

(Core :: DOM: Animation, task, P4)

Product:
Core
Component:
DOM: Animation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31562 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31562
Details from upstream follow.

Kevin Ellis <kevers@chromium.org> wrote:

Fix flakiness of wpt/web-animations/.../onfinish.html

assert_equals was being used for time comparisons, which allows for no
numerical precision tolerance. Instead, we should be using
assert_times_equal, which has a built in tolerance of 1 microsecond.

Bug: 1267535
Change-Id: I76be9723645f8e4457b35baa4fe516d6013c6eea

Reviewed-on: https://chromium-review.googlesource.com/3270992
WPT-Export-Revision: 35dddb6ca82f415bbddff1e994ce70f1647b346f

Component: web-platform-tests → DOM: Animation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 6

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f49716bb188c
[wpt PR 31562] - Fix flakiness of wpt/web-animations/.../onfinish.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f49716bb188c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.