Closed Bug 1740353 Opened 3 years ago Closed 3 years ago

Configure hunspell rlbox sandbox so AMO dictionaries have a smaller footprint

Categories

(Core :: Spelling checker, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: shravanrn, Assigned: shravanrn)

References

Details

Attachments

(1 file)

Initially in Bug 1739669, we had decided to use a heuristic of 7x the size of the dictionary, rounded to the power of two as a rough heuristic on how much memory hunspell takes. to spell check. Thus one of the larger dictionaries on addons.mozilla, which is the bg locale which is 8.6mb on disk would need a 64mb rlbox wasm sandbox.

However, the largest addons.mozilla dictionary https://addons.mozilla.org/en-US/firefox/addon/dico-ortografic-oc-lengadocian/ is about 9.53 mb on file, and does run fine in a 64mb sandbox, even though the heuristic says we need a 128mb sandbox. To reduce the memory necessary, we modify this heuristic to 6.4x. Thus any dictionary upto 10mb should fit inside the sandbox.

Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ea50c4f49ad
Configure hunspell rlbox sandbox so AMO dictionaries have a smaller footprint r=bholley
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Blocks: 1758626
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: