Port bug 1736565 for comm- trees
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox-esr91 fixed, firefox95 fixed, firefox96 fixed)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr91+
|
Details | Review |
Bug 1736565 worked out which tree to use for artifact builds based on the version number. The same would work for Thunderbird.
|
Assignee | |
Comment 1•3 years ago
|
||
This is the same configuration as for mozilla- trees as added in https://hg.mozilla.org/mozilla-central/rev/93e421a84361 except Thunderbird doesn't use comm-release.
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/integration/autoland/rev/6bc14c4e4abc Port bug 1736565 (Infer artifact build candidate tree based on version) for comm- trees. r=nalexander
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•3 years ago
|
||
Comment on attachment 9250097 [details]
Bug 1740381 - Port bug 1736565 (Infer artifact build candidate tree based on version) for comm- trees. r=willdurand,mhentges
Beta/Release Uplift Approval Request
- User impact if declined: Doesn't affect users, only Thunderbird developers, who would like to be able to do artifact builds of beta and ESR.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Doesn't affect the end product at all.
- String changes made/needed:
|
||
Comment 5•3 years ago
|
||
Comment on attachment 9250097 [details]
Bug 1740381 - Port bug 1736565 (Infer artifact build candidate tree based on version) for comm- trees. r=willdurand,mhentges
NPOTB for Firefox, approved for Beta.
|
|
||
Comment 6•3 years ago
|
||
| bugherder uplift | ||
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9250097 [details]
Bug 1740381 - Port bug 1736565 (Infer artifact build candidate tree based on version) for comm- trees. r=willdurand,mhentges
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Will allow Thunderbird developers to maintain Thunderbird 91 (the current release) more easily.
- User impact if declined: Doesn't affect users, only Thunderbird developers, who would like to be able to do artifact builds of beta and ESR.
- Fix Landed on Version: 96
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Doesn't affect the end product at all.
- String or UUID changes made by this patch:
|
|
||
Comment 8•3 years ago
|
||
Comment on attachment 9250097 [details]
Bug 1740381 - Port bug 1736565 (Infer artifact build candidate tree based on version) for comm- trees. r=willdurand,mhentges
Approved for ESR.
|
|
||
Comment 9•3 years ago
|
||
| bugherder uplift | ||
|
|
Assignee | |
Comment 10•3 years ago
|
||
Ah, damn! I forgot our ESR version number doesn't contain the letters E S and R. We could instead inspect MOZ_SOURCE_REPO which weirdly is an empty string for Firefox but is set in Thunderbird. Also if it was set in Firefox it could just be used directly by chopping the https://hg.mozilla.org/ off the front.
Description
•