1740411 - Remove EventRegions

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

Looking at the usage of EventRegions post-{bug 1738152}, I think we can remove it.

Comment 1

[Botond Ballo [:botond]]

While removing the remaining usages of EventRegions in APZ gtest code, I did find a few remaining tests that should be ported to mochitest, will do that in this bug as well.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Fix two tests in TestTreeManager.cpp that were providing invalid input data. r=hiro

SingleTouchData has two constructors, one which populates mScreenPoint,
and one which populates mLocalScreenPoint.

The latter is only appropriate for cases where the event is delivered
directly to an APZC, which expects "local" (ParentLayer) coordinates.

For cases where the event is delivered to the tree manager (as in
these tests), mScreenPoint must be populated because this is what
the hit tester looks at.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Port APZ gtests which use EventRegions to MockHitTester. r=hiro

The fact that they are using EventRegions suggests that they only
passed by accident with the default hit-tester (which is WRHitTester
taking an early exit to target the root, since WebRender isn't
actually running), rather than testing the scenario they are intended
to test.

This is actually a latent bug that was introduced in bug 1682180,
when these tests were incorrectly excluded from the "LayersOnly"
subclasses because they happened to pass with the WebRender
early-exit codepath.

Depends on D131683

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Port APZHitTestingTester.HitTestingRespectsScrollClip_Bug1257288 to mochitest. r=hiro

The test also has not been testing anything useful since bug 1682180
(it should have been a "LayersOnly"), but it's also not a good fit
for MockHitTester since it wants to test the hit test itself.

In mochitest form, it can exercise the scenario from bug 1257288
with the production WebRender hit testing codepath.

Depends on D131684

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Port APZEventRegionsTester.Bug1119497 to mochitest. r=hiro

As in the previous patch, this test wasn't testing anything useful
in its current form.

Depends on D131685

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Port APZEventRegionsTesterMock.Obscuration to mochitest. r=hiro

As in the previous patches, this wasn't testing anything useful.

Depends on D131686

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Remove code to set event regions in gtests. r=hiro

This code has been a no-op (in the sense that no one was looking
at the event regions) for Internal/Mock tests since bug 1731700,
and for other tests since bug 1682180.

Depends on D131687

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Remove WebRenderLayerScrollData::mEventRegions. r=hiro

Depends on D131688

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1740411 - Remove EventRegions. r=hiro

Depends on D131689

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d1b5a6a12b7
Fix two tests in TestTreeManager.cpp that were providing invalid input data. r=hiro
https://hg.mozilla.org/integration/autoland/rev/5fa9c8c9ee35
Port APZ gtests which use EventRegions to MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/bf6814958164
Port APZHitTestingTester.HitTestingRespectsScrollClip_Bug1257288 to mochitest. r=hiro
https://hg.mozilla.org/integration/autoland/rev/d003bbf097a0
Port APZEventRegionsTester.Bug1119497 to mochitest. r=hiro
https://hg.mozilla.org/integration/autoland/rev/9c728ac11127
Port APZEventRegionsTesterMock.Obscuration to mochitest. r=hiro
https://hg.mozilla.org/integration/autoland/rev/b6eb20b33df2
Remove code to set event regions in gtests. r=hiro
https://hg.mozilla.org/integration/autoland/rev/a098492547da
Remove WebRenderLayerScrollData::mEventRegions. r=hiro
https://hg.mozilla.org/integration/autoland/rev/ace2f4af2c29
Remove EventRegions. r=hiro

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/3d1b5a6a12b7
https://hg.mozilla.org/mozilla-central/rev/5fa9c8c9ee35
https://hg.mozilla.org/mozilla-central/rev/bf6814958164
https://hg.mozilla.org/mozilla-central/rev/d003bbf097a0
https://hg.mozilla.org/mozilla-central/rev/9c728ac11127
https://hg.mozilla.org/mozilla-central/rev/b6eb20b33df2
https://hg.mozilla.org/mozilla-central/rev/a098492547da
https://hg.mozilla.org/mozilla-central/rev/ace2f4af2c29