17405 - [DOGFOOD] Autocomplete against a name with no e-mail address leads to a crash

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[marina]

Steps to reproduce:
-open Address Book;
-click New message;
-enter in the "To" filed a first (or two) letters of the address that has NO
e-mail address in his card;
-hit enter
//note: mozilla crashes (it doesn't happen with the names that do have an e-mail
address)
*******observed with 1999-10-27-09 windows build on NT40*******

Comment 1

[Phil Peterson]

Nominate for dogfood

Comment 2

[hamerly]

crasher is dogfood, autocomplete is not necessarily.

Comment 3

[hangas]

JFD gets all the mail compose issues now.

Comment 4

[Jean-Francois Ducarroz]

I am on it...

Comment 5

[Jean-Francois Ducarroz]

I get the fix, I am looking for a code review...

Index: nsAbAutoCompleteSession.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/src/nsAbAutoCompleteSession.cpp,v
retrieving revision 1.14
diff -r1.14 nsAbAutoCompleteSession.cpp
195,196d194
< 				matchFound = PR_TRUE; // so we kick out of the loop
<
207a206,208
>
> 				if (! fullAddress || ! *fullAddress)
> 					continue;	/* something goes wrong with this entry, maybe the email address is missing. Just skip it... */
216a218,219
>
> 				matchFound = PR_TRUE; // so we kick out of the loop

Comment 6

[Jean-Francois Ducarroz]

mscott revied my patch.
Fixed and checked in.

Comment 7

[esther]

Using 19991028 build on win98, linux, and mac this is fixed.  It looks like no
match is found so it adds the domain.  Verified.

Comment 8

[Jean-Francois Ducarroz]

Right, that what appends, entries without email address are ignored.