Closed Bug 1740515 Opened 3 years ago Closed 3 years ago

Audit telemetry probes in netwerk/ and make sure them work with socket process

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

We have to add socket to record_in_processes, otherwise those telemetry probes won't be recorded.

:chutten, I'd like to ask if I need to request a data review for this patch?
If yes, which form should I fill?
Thanks.

Flags: needinfo?(chutten)

(In reply to Kershaw Chang [:kershaw] from comment #2)

:chutten, I'd like to ask if I need to request a data review for this patch?
If yes, which form should I fill?
Thanks.

Some context: we are working on socket process project, which is about moving some networking code to another process. Without adding socket in to record_in_processes, those telemetry probes won't work.

The data collection here doesn't expand or change except to include information about from which process it is collected, which is a very technical detail that previously didn't matter... so in short: Yes, it is my opinion that you do not need a data review request for this patch.

Flags: needinfo?(chutten)
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5aff7b71a7ca
Add 'socket' in record_in_processes for telemetry probes in socket process, r=necko-reviewers,valentin
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: