Audit telemetry probes in netwerk/ and make sure them work with socket process
Categories
(Core :: Networking, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: kershaw, Assigned: kershaw)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
We have to add socket
to record_in_processes
, otherwise those telemetry probes won't be recorded.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
:chutten, I'd like to ask if I need to request a data review for this patch?
If yes, which form should I fill?
Thanks.
Assignee | ||
Comment 3•3 years ago
|
||
(In reply to Kershaw Chang [:kershaw] from comment #2)
:chutten, I'd like to ask if I need to request a data review for this patch?
If yes, which form should I fill?
Thanks.
Some context: we are working on socket process project, which is about moving some networking code to another process. Without adding socket
in to record_in_processes
, those telemetry probes won't work.
Comment 4•3 years ago
|
||
The data collection here doesn't expand or change except to include information about from which process it is collected, which is a very technical detail that previously didn't matter... so in short: Yes, it is my opinion that you do not need a data review request for this patch.
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5aff7b71a7ca Add 'socket' in record_in_processes for telemetry probes in socket process, r=necko-reviewers,valentin
Comment 6•3 years ago
|
||
bugherder |
Description
•