1740566 - Use pathlib in the "python/mach" module

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task, P2)

Description

[Mitchell Hentges [:mhentges] 🦀]

Replace string paths with pathlib objects in the mach module.
Note: to ensure the scope of this bug doesn't explode, don't yet refactor any objects that are included in the context object provided to Mach commands - ensure that it keeps the same API for now.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1740566 - Update string paths to Pathlib objects in Mach module r?#build

mach/mach/virtualenv.py was not updated because Mitch is on the process of a
major refactor on it. It will get a Pathlib migration pass at a later time.

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1740566 - Make cwd in mach/CommandContext not optional r?#build

Provide dummy empty string value in test.

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1740566 - Remove unused class member r?#build

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f95096b3ddc
Make cwd in mach/CommandContext not optional r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/a2cc045d0216
Update string paths to Pathlib objects in Mach module r=mhentges,firefox-build-system-reviewers
https://hg.mozilla.org/integration/autoland/rev/cab9de0087ae
Remove unused class member r=firefox-build-system-reviewers,mhentges

Comment 5

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1740566) for causing python test failures on test_site_compatibility.py.
Backout link
Push with failures
Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/325d612978da
Make cwd in mach/CommandContext not optional r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/c30d30105938
Update string paths to Pathlib objects in Mach module r=mhentges,firefox-build-system-reviewers
https://hg.mozilla.org/integration/autoland/rev/31c6bdb69540
Remove unused class member r=firefox-build-system-reviewers,mhentges

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/325d612978da
https://hg.mozilla.org/mozilla-central/rev/c30d30105938
https://hg.mozilla.org/mozilla-central/rev/31c6bdb69540