Replace date template in Merino URLs
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | verified |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
Suggestions from Merino include the same %YYYYMMDDHH% URL template that suggestions from remote settings include. Firefox needs to substitute the current date and hour for the template just like it does for RS suggestions. We should move this logic up to the provider class.
Nan says we need this for 96 but not 95.
|
Assignee | |
Comment 1•3 years ago
|
||
This moves the template substitution logic from UrlbarQuickSuggest to
UrlbarProviderQuickSuggest, where it can be applied to all suggestions
regardless of source.
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e5a3b63b416 Replace timestamp templates in Merino URLs. r=nanj
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•3 years ago
|
||
STR for QA
- Set the following prefs:
browser.urlbar.merino.enabled = true
browser.urlbar.quicksuggest.remoteSettings.enabled = false
browser.urlbar.quicksuggest.dataCollection.enabled = true
If Merino is not yet live when you test this, then also set the endpoint pref to the staging server as below. However, it looks like the staging server is not currently serving suggestions, so you may need to set up a local Merino instance or we may need to coordinate with the Merino team to test this.
browser.urlbar.merino.endpointURL = https://stage.merino.nonprod.cloudops.mozgcp.net/api/v1/suggest
- Type "amazon" in the urlbar and use the arrow keys to select the quick suggest result, but don't press enter
- Verify the Amazon quick suggest URL contains 10 numbers at the end and not "%YYYYMMDDHH%". e.g. it should look like the following, but your 10 numbers will be different because they depend on the date and time: https://www.amazon.com/?tag=admarketus-20&ref=pd_sl_a318361095US592021111708
|
||
Comment 5•2 years ago
|
||
Verified the steps from comment4 on Win10/Ubuntu20.4/Mac10.13 using 96.0b5(20211214203716). I also set nordVpn to US in order to get the FF suggest. All results contained the following format at the end "https://www.amazon.com/?tag=admarketus-20&ref=pd_sl_a318361095US592021121515".
Description
•