{for win} content is missing when OS picker is set to Windows 11
Categories
(support.mozilla.org :: Knowledge Base Software, task)
Tracking
(Not tracked)
People
(Reporter: alice.wyman, Assigned: lmcardle)
Details
Go to any article with {for win} markup, such as:
- https://support.mozilla.org/en-US/kb/update-firefox-latest-release
- https://support.mozilla.org/en-US/kb/find-what-version-firefox-you-are-using
Select Windows 11 in the "Customize this article" OS picker and observe that {for win} content is missing.
I changed {for win} to {for win,win11} as a workaround in a couple of templates [1][2]
but this issue apparently affects all articles with {for win} markup.
[1]https://support.mozilla.org/en-US/kb/Template:optionspreferences/history
[2]https://support.mozilla.org/en-US/kb/templateoptionsorpreferences/history
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 1•3 years ago
|
||
I edited https://support.mozilla.org/en-US/kb/firefox-page-info-window and https://support.mozilla.org/en-US/kb/Template:contextmenu to change {for win} to {for win,win11} as a workaround for this bug. I'll edit other articles and templates as I come across them.
|
|
Reporter | |
Comment 2•3 years ago
•
|
||
Based on a PM from Fabi that SUMO dev is not sure that OS detection is working for Windows 11, I updated the article https://support.mozilla.org/en-US/kb/how-change-your-default-browser-windows/ to change the {for win11} section for Windows 11 to {for not win10} since the article only applies to Windows 10 and Windows 11. That way, that all systems except for Windows 10 will see content for the section that applies to Windows 11.
P.S. I found https://stackoverflow.com/questions/68614445/how-to-detect-windows-11-from-user-agent which links to bug 1693295
|
|
Reporter | |
Comment 3•3 years ago
•
|
||
If Windows 11 detection isn't working and the user doesn't set the OS picker to Windows 11, I think that SUMO KB articles for desktop will show Windows 11 users content for a "default" OS, which used to be Windows 8 - see bug 1527337.
Leo or Fabi, is the default OS now Windows 10? In that case (assuming this is a bug that won't get fixed any time soon) the Firefox article https://support.mozilla.org/en-US/kb/how-change-your-default-browser-windows/ will need another update, since many users on Windows 11 wouldn't notice that the "Customize this article" OS picker shows a different Windows version and will see Windows 10 instructions.
(EDIT) If SUMO detects Windows 11 as Windows 10 (see my comment 2 P.S. above) then KB articles will be customized for Windows 10. That's also a problem, since articles with different win10 and win11 content will show the wrong content to Windows 11 users who don't change the OS picker. I have a revision pending to one such article to remove the OS showfor markup. See https://support.mozilla.org/en-US/kb/how-change-your-default-browser-windows/history
If this is a bug that will be fixed soon, please let me know and I'll hold off on further updates.
|
Assignee | |
Comment 4•3 years ago
|
||
I've opened https://github.com/mozilla/kitsune/pull/4945 to add Windows 11 to the {for win} alias.
However, as you note Alice, we can't currently distinguish between Windows 10 and 11 when UA sniffing, meaning Windows 11 users will have the selector set to Windows 10. I've opened an issue to support detecting Windows 11 though a couple of alternative methods: https://github.com/mozilla/sumo-project/issues/966
We'll need to prioritise that work with the rest of the team, so I can't say yet when we'll work on it.
|
|
Assignee | |
Comment 5•3 years ago
|
||
We deployed the aforementioned fix today, so windows 11 now works with the {for win} alias.
|
|
Reporter | |
Comment 6•3 years ago
•
|
||
I verified that the {for win,win11} workaround is no longer needed bysetting the OS picker to Windows 11 in an article with {for win} content that wasn't visible before the fix, https://support.mozilla.org/en-US/kb/update-firefox-latest-release
The Windows 11 detection issue, https://github.com/mozilla/sumo-project/issues/966 is still open, however. I'll leave opening a new bugzilla report for that bug to Leo or Fabi.
|
|
Reporter | |
Comment 7•3 years ago
|
||
(from comment #6)
The Windows 11 detection issue, https://github.com/mozilla/sumo-project/issues/966 is still open, however. I'll leave opening a new bugzilla report for that bug to Leo or Fabi.
Comment in the above github issue, which is now closed:
LeoMcA commented on Mar 15
In AAQ: windows 11 should be detected properly in the "We've made some educated guesses about your current browser and operating system." section
In KB: an article with the {for win11} notation should show wrapped content automatically on windows 11
Description
•