1740620 - mach lint broken: fatal: ambiguous argument 'default': unknown revision or path not in the working tree.

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[:gerard-majax]

STR:
0. Use git-cinnabar

1. checkout current bookmarks/central
2. |mach lint --outgoing --warning --fix|

Expected:
mach lint does its job

Actual:

$ LC_ALL=C BUILD_DEBUG=1 ./mach lint --outgoing --warnings --fix
created virtual environment CPython3.9.8.final.0-64 in 43ms
  creator CPython3Posix(dest=/home/alexandre/Documents/codaz/Mozilla/MiscWork/mozilla-source/mozilla-unified/obj-browser-dbg/_virtualenvs/common, clear=False, no_vcs_ignore=False, global=False)
  activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator
error: problem with lint setup, skipping android-api-lint, android-checkstyle, android-format, android-javadoc, android-lint, android-test
fatal: ambiguous argument 'default': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
error running: /usr/bin/git log --name-only --diff-filter=AM --oneline --pretty=format: HEAD --not default
warning: no files linted
✖ 0 problems (0 errors, 0 warnings, 0 fixed)

Comment 1

[:gerard-majax]

$ git bisect log
git bisect start
# good: [7a5ebd55d45e6fedefb89edf3b8c4150569eebf1] Merge mozilla-central to autoland. a=merge
git bisect good 7a5ebd55d45e6fedefb89edf3b8c4150569eebf1
# bad: [91c97605371b8d6877c5329c9ac80e4acbfa1a92] Merge autoland to mozilla-central. a=merge
git bisect bad 91c97605371b8d6877c5329c9ac80e4acbfa1a92
# good: [656a19708f46bf1d38d378f9663689b471911144] Bug 1477548 - Lift mochitest stats helpers out to a dedicated file. r=ng
git bisect good 656a19708f46bf1d38d378f9663689b471911144
# good: [f30426214d50592f0eb1c8bb5fae74a23decf162] Bug 1707643 part 3: Fix mistakes in center-alignment reference-cases in some abspos grid item WPT tests, and mark them as passing. r=emilio
git bisect good f30426214d50592f0eb1c8bb5fae74a23decf162
# bad: [e821957b0f66b3b9eed194f8e1593b9a52a73235] Bug 1740230 - Unexpose :-moz-locale-dir and :-moz-lwtheme* from content. r=dholbert
git bisect bad e821957b0f66b3b9eed194f8e1593b9a52a73235
# good: [bfdb52fd706da6e10a989f638f9d92285276495a] Bug 1735937 - Flip gfx.offscreencanvas.enabled for WPT OffscreenCanvas related tests. r=jrmuizel
git bisect good bfdb52fd706da6e10a989f638f9d92285276495a
# good: [ea465ffe077362f18c121f111b0b8aff8a41d5df] Bug 1739701 - Add support for the arm64 Android emulator. r=gbrown,calu
git bisect good ea465ffe077362f18c121f111b0b8aff8a41d5df
# bad: [93ee7b6b50ae9f20980b2ac214c297d2c19506ea] Bug 1730120, close ContentViewer properly if initialization fails, r=nika
git bisect bad 93ee7b6b50ae9f20980b2ac214c297d2c19506ea
# bad: [325620f1473af2a63c801987f982c246bf6516e0] Bug 1738187 - Add telemetry for MoreFromMozilla section inside about:preferences r=preferences-reviewers,Gijs
git bisect bad 325620f1473af2a63c801987f982c246bf6516e0
# bad: [3065d9fabf4f13d6a1b8117c5ac75390f4bfee09] Bug 1739594: Don't hit network to resolve VCS-changed files r=ahal
git bisect bad 3065d9fabf4f13d6a1b8117c5ac75390f4bfee09
# first bad commit: [3065d9fabf4f13d6a1b8117c5ac75390f4bfee09] Bug 1739594: Don't hit network to resolve VCS-changed files r=ahal

Comment 2

[:gerard-majax]

get_outgoing_files() for git seems to use default instead of origin.

LC_ALL=C BUILD_DEBUG=1 ./mach lint --outgoing=origin --warnings --fix

works for me, I'm not sure if it is normal to be required now.

Comment 3

[Mike Hommey [:glandium]]

That's because of https://searchfox.org/mozilla-central/source/python/mozlint/mozlint/cli.py#88. It should probably be None instead.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #3)

It should probably be None instead.

Or removed, since None is the default anyways.

Comment 5

[:gerard-majax]

Removing the line, or changing the value to None does not seems to make lint tooling happy:

warning: linting the entire repo takes a long time, using --outgoing and --workdir instead. If you want to lint the entire repo, run ./mach lint .

Comment 6

[Mike Hommey [:glandium]]

That's bug 1740598.

Comment 7

[Andrew Halberstadt [:ahal]]

(In reply to Mike Hommey [:glandium] from comment #3)

That's because of https://searchfox.org/mozilla-central/source/python/mozlint/mozlint/cli.py#88. It should probably be None instead.

I think we have if outgoing checks elsewhere, so we'll need to set it to True and then take care to only forward it down to mozversioncontrol if we have a string (or something).

There's also:
https://searchfox.org/mozilla-central/source/python/mozlint/mozlint/cli.py#361

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1740620 - Fix regression to 'mach lint --outgoing' on Git, r?gerard-majax!

Comment 9

[Andrew Halberstadt [:ahal]]

Note tomorrow is a holiday in Canada, so I won't be around. If this solves the problem for you, feel free to land on my behalf (or commandeer if it needs changes). I didn't get around to testing it on Git, but it should fix the issue.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1739594

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9887da341d
Fix regression to 'mach lint --outgoing' on Git, r=gerard-majax

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2c9887da341d