Crash in [@ mozilla::net::TRRService::ConfirmationContext::Notify]
Categories
(Core :: Networking: DNS, defect, P2)
Tracking
()
People
(Reporter: aryx, Assigned: kershaw)
Details
(Keywords: crash, Whiteboard: [necko-triaged][necko-priority-queue])
Crash Data
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-release+
|
Details | Review |
Not new, ~30 crash reports per major release version.
Crash report: https://crash-stats.mozilla.org/report/index/30edcbcf-c813-404d-9602-ff7aa0211111
MOZ_CRASH Reason: MOZ_CRASH(Unknown timer)
Top 10 frames of crashing thread:
0 XUL mozilla::net::TRRService::ConfirmationContext::Notify netwerk/dns/TRRService.cpp:1044
1 XUL nsTimerImpl::Fire xpcom/threads/nsTimerImpl.cpp:620
2 XUL nsTimerEvent::Run xpcom/threads/TimerThread.cpp:264
3 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1142
4 XUL mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:330
5 XUL MessageLoop::Run ipc/chromium/src/base/message_loop.cc:306
6 XUL nsThread::ThreadFunc xpcom/threads/nsThread.cpp:390
7 libnss3.dylib _pt_root nsprpub/pr/src/pthreads/ptthread.c:201
8 libsystem_pthread.dylib libsystem_pthread.dylib@0x393a
9 libsystem_pthread.dylib libsystem_pthread.dylib@0x3886
Comment 1•2 years ago
|
||
I think this does not need to crash, we should just remove MOZ_CRASH.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16fe53e83b2a Remove MOZ_CRASH, r=necko-reviewers,dragana
Comment 4•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 5•2 years ago
|
||
The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox102
towontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 6•2 years ago
|
||
(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #5)
The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox102
towontfix
.For more information, please visit auto_nag documentation.
Let's uplift this, since the risk of uplifting this is zero.
Assignee | ||
Comment 7•2 years ago
|
||
Comment on attachment 9280216 [details]
Bug 1740677 - Remove MOZ_CRASH, r=#necko
Beta/Release Uplift Approval Request
- User impact if declined: Firefox could crash.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: N/A
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch only removes a
MOZ_CRASH
. - String changes made/needed: N/A
- Is Android affected?: No
Comment 8•2 years ago
|
||
Comment on attachment 9280216 [details]
Bug 1740677 - Remove MOZ_CRASH, r=#necko
We are out of the beta cycle and mozilla-beta was merged to mozilla-release before we build our RC. Morphing this into a release build uplift request.
Updated•2 years ago
|
Comment 9•2 years ago
|
||
Comment on attachment 9280216 [details]
Bug 1740677 - Remove MOZ_CRASH, r=#necko
Very low risk crash fix, taking for our 102 release and 102 esr release builds, thanks.
Comment 10•2 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 11•2 years ago
|
||
bugherder uplift |
Description
•