1740747 - Missing unlock in gfxFT2FontBase::InitMetrics()

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

After
FT_Face face = LockFTFace();

if (MOZ_UNLIKELY(!face)) {
...
we return without out unlocking (UnlockFTFace()).

This could cause a deadlock if this were to happen, I presume. (I imagine this is hard to hit)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1740747: Add missing UnlockFTFace() for unlikely case of font removed during init r=jfkthame

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bb5bef73e36
Add missing UnlockFTFace() for unlikely case of font removed during init r=jfkthame

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6bb5bef73e36