Closed Bug 1740806 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31605 - [GridFragmentation] Position items based on their row position.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31605 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31605
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[GridFragmentation] Position items based on their row position.

Previously we'd decide if a grid-item should be placed in the current
fragmentainer based on their global position.

This was ok - but a better strategy is to try and keep them with their
row. This wasn't initially important, but as break avoidance is row
based, when we try to shift a row to a subsequent fragmentainer we'll
potentially end up with an item which has already been placed.

This has the side-effect that a grid-item with a negative block-start
margin, may be placed above the start fragmentainer edge - which seems
ok.

I added this as a tentative testcase.

Bug: 614667
Change-Id: I65486307fd72f8e5f8cb7f87ebce66c5569deedf
Reviewed-on: https://chromium-review.googlesource.com/3276728
WPT-Export-Revision: 3c85c003c03fd879f737471a628af3a293ac28d2

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/grid/grid-item-fragmentation-026.html: FAIL

New Tests That Don't Pass

/css/css-break/grid/grid-item-fragmentation-026.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29d23d019702
[wpt PR 31605] - [GridFragmentation] Position items based on their row position., a=testonly
https://hg.mozilla.org/integration/autoland/rev/1a95ad8789fa
[wpt PR 31605] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/29d23d019702
https://hg.mozilla.org/mozilla-central/rev/1a95ad8789fa

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.