Closed Bug 1740835 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 31611 - [FlexNG] Set MinSizeShouldEncompassIntrinsicSize

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31611 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31611
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Set MinSizeShouldEncompassIntrinsicSize

SetMinBlockSizeShouldEncompassIntrinsicSize() on a flex item
to allow the item to grow as a result of fragmentation.

In order for this flag to have an effect on flex items inside
a column flex container, we also had to SetIsFixedBlockSize()
to false.

This will be used to expand the flex lines if needed.

Bug: 660611
Change-Id: I8890cc54262c14664706b9cb9efb141a453dceff

Reviewed-on: https://chromium-review.googlesource.com/3276791
WPT-Export-Revision: 8e47c45de18bf39548f027b761b17a3901a886bb

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/single-line-column-flex-fragmentation-007.html: FAIL
/css/css-break/flexbox/single-line-column-flex-fragmentation-008.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/single-line-column-flex-fragmentation-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-008.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9f11a82778e [wpt PR 31611] - [FlexNG] Set MinSizeShouldEncompassIntrinsicSize, a=testonly https://hg.mozilla.org/integration/autoland/rev/a64e1932635f [wpt PR 31611] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f9f11a82778e
https://hg.mozilla.org/mozilla-central/rev/a64e1932635f

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.