Closed Bug 1740918 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31615 - WebTransport: Use UseCounter::Count

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31615 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31615
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

WebTransport: Use UseCounter::Count

Use UseCounter::Count in web_transport.cc instead of
ExecutionContext::CountUse. The difference that that the UseCounter
variant performs a null check and so can safely be used after the
ExecutionContext has been destroyed.

Add a test that it safe to access WebTransport getters even after
the frame in which the WebTransport was created has been destroyed.

BUG=1269525

Change-Id: I4af26f3e34adcfcf28bf39f99f6e694fb61d91c0
Reviewed-on: https://chromium-review.googlesource.com/3276626
WPT-Export-Revision: 87f243d2a1de376b61c27b1ef65d0cfb2ac062e1

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webtransport/in-removed-iframe.https.html
in-removed-iframe: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4ace95fcb66
[wpt PR 31615] - WebTransport: Use UseCounter::Count, a=testonly
https://hg.mozilla.org/integration/autoland/rev/35d2dc2375d3
[wpt PR 31615] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a4ace95fcb66
https://hg.mozilla.org/mozilla-central/rev/35d2dc2375d3

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.