1740987 - All tabs gone, about:newtab blank, about:support without values (Browser Console: "TypeError: PlacesUtils.obfuscateUrlForXulStore is not a function BrowserGlue.jsm:3342:36")

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Darkspirit]

But can't reproduce it with mozregression.

Comment 1

[Darkspirit]

Restoring previous session is no longer possible: One window opens with one about:newtab that is empty like about:blank.
The "Sign In" button in the Main Menu does not have its text.

Comment 2

[Darkspirit]

[fluent] Missing message in locale de: content-blocking-etp-standard-tcp-rollout-checkbox
[fluent] Missing message in locale de: content-blocking-etp-standard-tcp-rollout-description
ATTENTION: default value aof option mesa_glthread overridden by environment.
[Parent 63893, TaskController #2] WARNING: failed to create memfd: Zu viele offene Dateien: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/shared_memory_posix.cc:306
[Parent 63893, TaskController #0] WARNING: failed to create memfd: Zu viele offene Dateien: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/shared_memory_posix.cc:306
[Parent 63893, TaskController #3] WARNING: failed to create memfd: Zu viele offene Dateien: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/shared_memory_posix.cc:306
[Parent 63893, TaskController #2] WARNING: failed to create memfd: Zu viele offene Dateien: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/shared_memory_posix.cc:306
[...]

Too many open files?!

Comment 3

[Darkspirit]

Session restore + about:newtab + about:support worked again after a reboot.

Comment 4

[Darkspirit]

I could bring my tabs back by using <profile>/sessionstore-backups/upgrade.jsonlz4-20211111211702 as the new <profile>/sessionstore.jsonlz4

Comment 5

[Cosmin Sabou [:CosminS]]

Hi, I updated to latest nightly on Windows (20211112213406) signed in and could not reproduce. Tried a fresh install & update via About Nightly (from both 20211111211702 and 20211112092317 to latest version) on Linux (Build ID 20211112213406) and was also not able to reproduce. Aryx could you double check this when you're around? Thank you.

Comment 6

[Pulse]

Probably related, As of build 20211112213406 Bookmark sidebar no longer remembers settings. All bookmarks open collapsed regardless of previous setting.

Comment 7

[Cosmin Sabou [:CosminS]]

(In reply to Pulse from comment #6)

Probably related, As of build 20211112213406 Bookmark sidebar no longer remembers settings. All bookmarks open collapsed regardless of previous setting.

This one I can repro, both on windows and linux nightly build 20211112213406. Tested on previous build (20211112092317) and works as expected.

Comment 8

[Albert Scheiner [:alberts]]

Change to all platforms based on feedback: https://matrix.to/#/!evDrGXhEMVVjldSwGf:mozilla.org/$aOTV-RbHegn-sTfRkHpb9OwT3Q8ANlH2hKIYyo6YeYQ?via=mozilla.org&via=matrix.org&via=matrix.zeteo.me

Comment 9

[Purajit]

I feel the component should be much wider than "Bookmarks & History", since it prevents you from accessing any pages, including about:, and empties your session.

(Happened to me on Mac OS Big Sur; reverted my build and restored my session backup)

Comment 10

[Marco Bonardo [:mak]]

let's land an emergency fix, then I'll file a new bug with a test for this case.

Comment 11

[Marco Bonardo [:mak]]

Attachment: WIP: Bug 1740987 - Correct typo in BrowserGlue migration.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/7980a83e7099
Correct typo in BrowserGlue migration.

Comment 13

[Marco Bonardo [:mak]]

Mark, could you please do a post-facto review when you're around?
In the end I also added a quick test.
Testing that BrowserGlue migration doesn't break is a bit more complex though because most migrations do something only if there's something to migrate, and each case is different...

Comment 14

[Marco Bonardo [:mak]]

(In reply to Darkspirit from comment #0)

But can't reproduce it with mozregression.

The reason is that the broken migration only runs if there's something to migrate, in this case it was open folders in a Places view.
So in an old nightly (browser.migration.version = 120) you should open the bookmarks sidebar, open a bookmarks folder and close the browser. Then launching the new nightly (browser.migration.version = 121) on the same profile, it will then try to migrate and boom.

Comment 15

[mac198442]

Could new nightlys be built with this fix? Current nightlys end up messing up your profile.

Comment 16

[Marco Bonardo [:mak]]

(In reply to mac198442 from comment #15)

Could new nightlys be built with this fix? Current nightlys end up messing up your profile.

New Nightlies have already been created. I'm not sure if updates have been sent out yet, I just tried reinstalling the latest nightly over and it works fine.

If you lost the session, you can find backups in the <profile>/sessionstore-backups/ folder, just copy a backup to the main profile folder as sessionstore.jsonlz4 while Firefox is closed.

Comment 19

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Marco Bonardo [:mak] from comment #16)

(In reply to mac198442 from comment #15)

Could new nightlys be built with this fix? Current nightlys end up messing up your profile.

New Nightlies have already been created. I'm not sure if updates have been sent out yet, I just tried reinstalling the latest nightly over and it works fine.

If you lost the session, you can find backups in the <profile>/sessionstore-backups/ folder, just copy a backup to the main profile folder as sessionstore.jsonlz4 while Firefox is closed.

Windows Nightly's are trying to build but the SUT (Start Up Tests) have failed 2 times now so the builds are not completing.

Comment 20

[Marco Bonardo [:mak]]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #19)

Windows Nightly's are trying to build but the SUT (Start Up Tests) have failed 2 times now so the builds are not completing.

I'm on Windows Nightly 20211113100827 that is built from this push. I see those SUT failures, but builds exist (for win64 at least).

Comment 21

[mac198442]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #19)

(In reply to Marco Bonardo [:mak] from comment #16)

(In reply to mac198442 from comment #15)

Could new nightlys be built with this fix? Current nightlys end up messing up your profile.

New Nightlies have already been created. I'm not sure if updates have been sent out yet, I just tried reinstalling the latest nightly over and it works fine.

If you lost the session, you can find backups in the <profile>/sessionstore-backups/ folder, just copy a backup to the main profile folder as sessionstore.jsonlz4 while Firefox is closed.

Windows Nightly's are trying to build but the SUT (Start Up Tests) have failed 2 times now so the builds are not completing.

Was not an issue with restoring the session, was that the bookmarks toolbar menu was completely empty and then when I went back to yesterdays build was empty there as well. If i went to manage bookmarks the bookmarks toolbar entries were there they just did not display in the UI.

Comment 22

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

New Nightly builds are available for all platforms and languages. Updates have been re-enabled.

Comment 24

[Mark Banner (:standard8)]

Patch looks fine, thank you.

Comment 25

[Daniel Bodea [:danibodea]]

I have managed to reproduce this issue in Win 10 and Ubuntu 20.04.3 LTS using the following steps:

1. Open Nightly v96.0a1 from 2021-11-12
2. Login with a sync account that has some data.
3. Go to about:config
4. Change the value of the pref browser.migration.version from 121 to 120
5. Go to about:preferences
6. Activate session restore
7. Close session
8. Reopen the same profile
   Expected Result: The session is restored properly.
   Actual Result: The session is lost and the pages are improperly displayed.

I have also verified the fix using the same steps in the latest Nightly v97.0a1 from 2021-12-28 and Beta v96.0b9, as it does not appear to reproduce anymore in Windows 10 and Ubuntu 20.04.3.

@Darkspirit:

1. I could not reproduce the main issue in Mac OS. Do you think it should also reproduce in Mac OS?
2. It appears as if it could be intermittent. Is that a possibility?
3. How do I force the browser.migration.version to stay as 120 by normal user behavior?

@CosminS:
I also could not reproduce the issue with the bookmarks sidebar. Can you verify whether the secondary issue is fixed in the latest builds? (or provide detailed steps to repro)

Comment 26

[Cosmin Sabou [:CosminS]]

Latest builds look fine after the fix in comment 12.

Comment 27

[Mark Banner (:standard8)]

(In reply to Bodea Daniel [:danibodea] from comment #25)

4. Change the value of the pref browser.migration.version from 121 to 120

To be safe, you should be creating the test profile using a build between where this regressed and where the fix landed. That would guarantee that you haven't already got upgraded data in your profile.

@Darkspirit:

1. I could not reproduce the main issue in Mac OS. Do you think it should also reproduce in Mac OS?
2. It appears as if it could be intermittent. Is that a possibility?

This shouldn't be platform dependent, but not using a regressed build is potentially going to make it so you can't reproduce it.

3. How do I force the browser.migration.version to stay as 120 by normal user behavior?

You can't. This is a pref that is upgraded occasionally as Firefox upgrades. Forcing it to a lower version would cause migration to occur on every startup which could potentially cause its own issues.

Comment 28

[Daniel Bodea [:danibodea]]

I will set this bug as verified based on comment 25. It was properly verified on 2-3 platforms and it could not even be reproduced on the third.