Closed Bug 1741082 Opened 3 years ago Closed 3 years ago

Remove freenode remnants from ChatZilla in SeaMonkey

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.93
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.11)

Attachments

(1 file)

We still have some references to freenode in cz. Mostly help and tests. We only need one entry for networks and should change the remaining ones to libera.chat.
Also freenode now only connects via sasl and needs SSL/TLS so access via port 6667 can be removed.

[Approval Request Comment]
Regression caused by (bug #): freenode self destruct
User impact if declined: clutter remains
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): trivial cleanups.
String changes made by this patch: one for help display which can not be assigned a new variable unfortunately.

Attachment #9250624 - Flags: review?(iannbugzilla)
Attachment #9250624 - Flags: approval-comm-release?
Attachment #9250624 - Flags: approval-comm-esr60?
Whiteboard: SM2.53.11
Blocks: 1716544
Comment on attachment 9250624 [details] [diff] [review]
1741082-freenodecleanup-25311.patch

>+++ b/suite/extensions/irc/xul/content/networks.js
>@@ -115,16 +105,20 @@ function networksGetDefaults()
>                   {hostname: "eu.ircnet.org", port:6667},
>                   {hostname: "us.ircnet.org", port:6667}]};
>     networks["efnet"] = {
>         displayName:  "efnet",
>         servers: [{hostname: "irc.efnet.org", port: 6667}]};
>     networks["hispano"] = {
>         displayName:  "hispano",
>         servers: [{hostname: "irc.irc-hispano.org", port: 6667}]};
>+    networks["freenode"] = {
>+        displayName:  "freenode",
>+        servers: [{hostname: "chat.freenode.net", port:6697, isSecure: true},
>+                  {hostname: "chat.freenode.net", port:7000, isSecure: true}]};
Need to keep non-SSL one as that is now available again:
 {hostname: "chat.freenode.net", port:6667},

r/a=me with that fixed.
Attachment #9250624 - Flags: review?(iannbugzilla)
Attachment #9250624 - Flags: review+
Attachment #9250624 - Flags: approval-comm-release?
Attachment #9250624 - Flags: approval-comm-release+
Attachment #9250624 - Flags: approval-comm-esr60?
Attachment #9250624 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8f32921fc0bf
Clean up freenode usage in ChatZilla. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Need to keep non-SSL one as that is now available again:
{hostname: "chat.freenode.net", port:6667},
Fixed in checkin. I added it after the secure entries. Cz would otherwise try to connect to port 6667 as default.

Target Milestone: --- → seamonkey 2.93
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: