1741089 - Don't make menupopups and panel leave unslotted children.

Status: RESOLVED FIXED

(Core :: XUL, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741089 - Make async OpenMenu simpler/sound. r=NeilDeakin,mstange

There's only one caller of it and it's not sound: The runnable captures a
raw frame pointer etc. Instead, just do a dispatch to the main thread
and call OpenMenu there. This simplifies the following patch.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741089 - Make attachShadow() not reframe the shadow host unconditionally. r=smaug,#layout-reviewers

This is needed for the next patch to work.

Depends on D131082

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741089 - Don't make menupopups and panels leave unslotted children. r=Gijs,mconley,bgrins

This is a more generic fix for
https://phabricator.services.mozilla.com/D131080 that we might want to
take instead. I'm not aware of other tests triggering the same issue but
this causes behavior to be a bit more predictable.

Context: We have tests that query the style of menupopups/menuitems that
are not in the flat tree (that is, that are children of a shadow host,
but are not slotted). That makes no sense, because the flat tree is how
we determine where to inherit from (so the styles that we were returning
before this bug are wrong, they just happen to work for that particular
test).

Panels and menupopups have some lazy initialization code that before
this patch left a shadow root attached to the element but no slot.
Instead, don't even bother to create a shadow root (and do that lazily
as well). It's a bit more predictable behavior, and is also less work
during startup, so should be a win.

We couldn't do it before the previous patches because attaching the
shadow root will reframe the popup, and the menupopup code didn't
deal well with that.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741089 - Revert test changes from bug 1483798 which are no longer needed. r=#extension-reviewers

This backs out D131080 as it shouldn't be needed after the previous
patches.

Depends on D131081

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c921d8e51bd
Make async OpenMenu simpler/sound. r=mstange

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on test_bug557987.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/9013267e971989bbd4af8d08108338b3e39e1440

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=5c921d8e51bd137a440f8c8ee7669fff2133d865&selectedTaskRun=Z_JrHbf4TJ-tYY3qZJio1g.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=358199652&repo=autoland&lineNumber=4511

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c5c5fc70a4
Make attachShadow() not reframe the shadow host unconditionally. r=smaug

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9afe46184c00
Don't make menupopups and panels leave unslotted children. r=mconley

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/28c5c5fc70a4
https://hg.mozilla.org/mozilla-central/rev/9afe46184c00

Comment 10

[Phabricator Automation]

Comment on attachment 9250627 [details]
Bug 1741089 - Make async OpenMenu simpler/sound. r=NeilDeakin,mstange

Revision D131082 was moved to bug 1729805. Setting attachment 9250627 [details] to obsolete.