1741190 - Add a profiler preset for necko

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Valentin Gosu [:valentin]]

The default presets don't profile the threads we normally care about in networking bugs (DNS, SocketTransportThread, StreamTransportThread, etc).

Comment 1

[Julien Wajsberg [:julienw]]

This is where the presets are defined: https://searchfox.org/mozilla-central/rev/3c8a7970944daaf917b547dffc0790bcd37cadc1/devtools/client/performance-new/popup/background.jsm.js#100

Feel free to add a preset there :-) It may be a good idea to wait a few days though, because Florian is currently changing the existing presets a bit.

Comment 2

[Valentin Gosu [:valentin]]

Thanks. I'll give it a few days.

Comment 3

[Florian Quèze [:florian]]

(In reply to Julien Wajsberg [:julienw] from comment #1)

It may be a good idea to wait a few days though, because Florian is currently changing the existing presets a bit.

Doing this in bug 1741235.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

The profiler already supports recording MOZ_LOG's as markers by including "profilermarkers" in the MOZ_LOG env var value.

It would be cool figure out whether we can include this either by default or as an option when capturing profiles with this networking preset.

Comment 5

[Valentin Gosu [:valentin]]

Attachment: Bug 1741190 - Add a profiler preset for necko r=#necko

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/817dd8236d41
Add a profiler preset for necko r=necko-reviewers,kpatenio,dragana,julienw

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_xpcom_graph_wait

Backout link: https://hg.mozilla.org/integration/autoland/rev/ea1661d1c9a86ae325ae4139255f01379dba7012

Push with failures

Failure log

 INFO - TEST-PASS | toolkit/components/backgroundtasks/tests/browser/browser_xpcom_graph_wait.js | resource://testing-common is not substituted - true == true - 
[task 2021-12-01T06:27:25.489Z] 06:27:25     INFO - Buffered messages finished
[task 2021-12-01T06:27:25.489Z] 06:27:25     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/backgroundtasks/tests/browser/browser_xpcom_graph_wait.js | 0 == -11 - JS frame :: chrome://mochitests/content/browser/toolkit/components/backgroundtasks/tests/browser/browser_xpcom_graph_wait.js :: test_xpcom_graph_wait :: line 216
[task 2021-12-01T06:27:25.489Z] 06:27:25     INFO - Stack trace:
[task 2021-12-01T06:27:25.489Z] 06:27:25     INFO - chrome://mochitests/content/browser/toolkit/components/backgroundtasks/tests/browser/browser_xpcom_graph_wait.js:test_xpcom_graph_wait:216
[task 2021-12-01T06:27:25.493Z] 06:27:25     INFO - Not taking screenshot here: see the one that was previously logged

Comment 8

[Valentin Gosu [:valentin]]

It seems to be caused by the inclusion of the cache i/o thread in the other patch.
With only this patch there is no failure. https://treeherder.mozilla.org/jobs?repo=try&revision=8485d53ab76f1f404662b06ec7472dac3e5c2ed0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05ebe7a9f054
Add a profiler preset for necko r=necko-reviewers,kpatenio,dragana,julienw

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/05ebe7a9f054