1741196 - MemoryDistribution's C++ API would be clearer with `size_t` than `uint64_t`

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P3)

Description

[Chris H-C :chutten|RustWeek (Back May 25)]

C++ has an explicit integral type for representing the sizes of things in memory: size_t. We should totally be taking that in MemoryDistribution::Accumulate instead of uint64_t.

(( In at least some cases they're the same width anyway, but let's not pass up a chance to use types to communicate with our users ))

Comment 1

[Perry McManis [:perry.mcmanis]]

GleanMemoryDistribution in rust/glean core is i64, should I also be updating that to usize so I can move this to size_t as well? https://searchfox.org/mozilla-central/source/toolkit/components/glean/bindings/private/MemoryDistribution.cpp#53

I can just leave it if we prefer m-c only changes or if it would not be appropriate to change in glean

Comment 2

[Chris H-C :chutten|RustWeek (Back May 25)]

This is just for the FOG-side changes where we can break the API and fix the consumers all at once.

My recommendation is to file a follow-up for the Glean SDK to consider that change.

Comment 3

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1741196 - Modify MemoryDistribution::Accumulate() to take size_t instead of u_int64 r?chutten

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e6f8694537a
Modify MemoryDistribution::Accumulate() to take size_t instead of u_int64 r=chutten

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2e6f8694537a