Closed Bug 1741244 Opened 2 years ago Closed 2 years ago

Use Microsoft Media Foundation H.264 video encoder for WebRTC

Categories

(Core :: WebRTC: Audio/Video, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: jhlin, Assigned: jhlin)

References

Details

Attachments

(6 files)

Windows s-mode doesn't allow unsigned libraries and could stop us from using OpenH264.

Depends on D137314

Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77104570d24e
p1: support software MFT video encoders. r=alwu,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/481fb3a2b3c6
p2: get MPEG header data for only H.264. r=alwu,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/492163502bd8
p3: reject simulcast request gracefully. r=alwu
https://hg.mozilla.org/integration/autoland/rev/a3782e11e270
p4: return correct VP9 info. r=alwu
https://hg.mozilla.org/integration/autoland/rev/84d347955733
p5: proper assignment of FEC setting to encoders in SoftwareFallbackWrapper. r=mjf

Initializing platform encoders often takes some time and the frame
rate measured is lower than actual number when the counting starts as
soon as connection established. Delaying the measurement until there
is at least some frame encoded makes it more accurate.

Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09598037b0dc
p1: support software MFT video encoders. r=alwu,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/0778acd1d8e9
p2: get MPEG header data for only H.264. r=alwu,media-playback-reviewers
https://hg.mozilla.org/integration/autoland/rev/0b63f292c9f8
p3: reject simulcast request gracefully. r=alwu
https://hg.mozilla.org/integration/autoland/rev/b671883b5fc9
p4: return correct VP9 info. r=alwu
https://hg.mozilla.org/integration/autoland/rev/7fe7b3011e6f
p5: proper assignment of FEC setting to encoders in SoftwareFallbackWrapper. r=mjf
https://hg.mozilla.org/integration/autoland/rev/5286475acad3
p6: wait for frame encoded in capture throttle test. r=jib
Regressions: 1762727

(In reply to Pulsebot from comment #9)

Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09598037b0dc
p1: support software MFT video encoders. r=alwu,media-playback-reviewers

This patch doesn't sound specific to H264. Is it? If not, maybe rename this bug to more accurately reflect scope?

(In reply to Pulsebot from comment #9)

https://hg.mozilla.org/integration/autoland/rev/09598037b0dc
p1: support software MFT video encoders. r=alwu,media-playback-reviewers

Is there a bug filed for removing the early beta condition from this pref?

In bug 1766311, platform encoders were disabled except for Android.

Flags: needinfo?(jolin)

(In reply to John Lin [:jhlin][:jolin] from comment #13)

In bug 1766311, platform encoders were disabled except for Android.

https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#9629 is the condition I was referring to.

Flags: needinfo?(jolin)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)

(In reply to John Lin [:jhlin][:jolin] from comment #13)

In bug 1766311, platform encoders were disabled except for Android.

https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#9629 is the condition I was referring to.

This pref is only in effect when media.webrtc.platformencoder is on.

Flags: needinfo?(jolin)
You need to log in before you can comment on or make changes to this bug.