1741247 - IOUtils unknown errors do not report the nsresult error code

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect, P3)

Description

[Beth Rennie [:beth] (she/her)]

When IOUtils encounters an error that it has not yet mapped in IOUtils::RejectJSPromise, it will only include the error code in the message if the IOError was constructed without a message.

Ideally, we would like to include this error code so that we can then add more mapping of nsresult errors we encounter to DOMExceptions.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1741247 - Include nsresult error codes in errors IOUtils does not know how to map r?gijs

Presently, if IOUtils encounters an error that it does not know how to map to
a DOMException (via RejectJSPromise), it will only include the nsresult error
code if the IOError was constructed without a message. This hides the root
cause of errors.

Now we always include the error code when rejecting with an UnknownError.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce199e98a0c5
Include nsresult error codes in errors IOUtils does not know how to map r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1741247, Bug 1723082, Bug 1736175) for causing PathUtils.normalize failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/72c397486d4cec809c954f4be3df881c2db93d56
Push with failures, failure log.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66bc77a38617
Include nsresult error codes in errors IOUtils does not know how to map r=Gijs

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/66bc77a38617