1741409 - Running sessionrestore talos test locally fails with "Mozilla crash reason: Missing chrome or resource URLs: chrome://global/skin/icons/warning-16.png"

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Description

[Mark Banner (:standard8)]

Running the sessionrestore talos tests locally fails with

13:13:19     INFO -  PID 63828 | Exiting due to channel error.
13:13:19     INFO -  Terminating psutil.Process(pid=63828, name='firefox', started='13:13:17')
13:13:19     INFO -  TEST-INFO | 63828: exit 1
13:13:19     INFO -  mozcrash checking /var/folders/6x/x01fpl8s7m11qpvrhbw0svf80000gp/T/tmpu8jqjkma/profile/minidumps for minidumps...
13:13:19     INFO -  mozcrash Copy/paste: /Users/mark/.mozbuild/minidump_stackwalk/minidump_stackwalk /var/folders/6x/x01fpl8s7m11qpvrhbw0svf80000gp/T/tmpu8jqjkma/profile/minidumps/9A0E8B1E-47B9-4986-BFF2-CD45FA60B51D.dmp /Users/mark/dev/gecko/objdir-ff-opt/dist/crashreporter-symbols
13:13:20     INFO -  mozcrash Saved minidump as /Users/mark/dev/gecko/testing/mozharness/build/blobber_upload_dir/9A0E8B1E-47B9-4986-BFF2-CD45FA60B51D.dmp
13:13:20     INFO -  mozcrash Saved app info as /Users/mark/dev/gecko/testing/mozharness/build/blobber_upload_dir/9A0E8B1E-47B9-4986-BFF2-CD45FA60B51D.extra
13:13:20     INFO -  PROCESS-CRASH | sessionrestore | application crashed [@ XUL + 0x6045a4]
13:13:20     INFO -  Crash dump filename: /var/folders/6x/x01fpl8s7m11qpvrhbw0svf80000gp/T/tmpu8jqjkma/profile/minidumps/9A0E8B1E-47B9-4986-BFF2-CD45FA60B51D.dmp
13:13:20     INFO -  Mozilla crash reason: Missing chrome or resource URLs: chrome://global/skin/icons/warning-16.png

The issue is that testing/talos/talos/startup_test/sessionrestore/profile/sessionstore.jsonlz4 has a reference to chrome://global/skin/icons/warning-16.png in it.

This is in the tab at index 5 of the first window. That one seems to be mainly different to the rest of the tabs in the window, I'm not sure why that is, but maybe a mistake when it was originally generated - the sessionstore.js file in the directory next to it does not reference warning-16.png.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1741409 - Remove reference to a no longer present warning-16.png in the sessionrestore file for Talos tests. r?gijs!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dae362ce58d0
Remove reference to a no longer present warning-16.png in the sessionrestore file for Talos tests. r=Gijs,perftest-reviewers,sparky

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/dae362ce58d0