174141 - Right-click another tab and select Close messes up back history

Status: RESOLVED DUPLICATE of bug 173703

(SeaMonkey :: Tabbed Browser, defect)

Description

[David Tenser [:djst]]

Weird stuff when doing the following...

Steps to reproduce:
1. Open three tabs with (different web pages).
2. Select tab 2 (the middle tab)
3. Right-click on the first tab and select Close

Actual results:
Focus is now correctly on tab 1, but the contents is from tab 2, and the
Back/Forward history is now broken for the selected tab (history actually works,
but you need to press Backspace; the Back button is disabled).

Expected results:
Focus should be on tab 1 and the contents should also be on tab 1.

Comment 1

[guanxi]

Please include your build ID and platform.

The instructions are confusing:

"3. Right-click on the first tab and select Close"
"Focus is now correctly on tab 1, but the contents is from tab 2"

Isn't that what's supposed to happen?  If you right-click on tab#1 and click
close, then,
  1)  OldTab1 should dissapear
  2)  OldTab2 should become NewTab1 and display OldTab2 contents

Perhaps I misunderstand?


History works fine for me after following the steps, but I'm using 1.01
(2002082606) on Win2K.

Comment 2

[David Tenser [:djst]]

Using build 2002101504 WinXP. Allow me to clarify:

Steps to reproduce:
1. Open three tabs with (different web pages). Let's call them oldtab1 to oldtab3.
2. Select oldtab2 (the middle tab)
3. Right-click on oldtab1 (the first tab) and select Close. There are now two
tabs left: newtab1 (previously oldtab2) and newtab2 (previously oldtab3).

Actual results:
Focus is now correctly on newtab1, but the contents is from newtab2, and the
Back/Forward history is now broken for the selected tab (history actually works,
but you need to press Backspace; the Back button is disabled).

Expected results:
Focus should be on newtab1 and the contents should also be for newtab1.

Comment 3

[David Tenser [:djst]]

I first discovered this in a nightly Phoenix build and then tested it in Mozilla
to see if the problem was there too, which it was. Anyway, this seems to have
been fixed in Phoenix 0.3, but it's still there in Mozilla.

Comment 4

[[e-mail]]

Attachment: Proposed patch

Unfortunately when I optimized the select events that happen on the tabpanels
I forgot that tabbrowser was relying on them :-(

Comment 5

[WADA:World Anti-bad-Duping Agency]

Problem of this bug has been almost resolved by trunc build(Win2-ZIP on Win-Me).

However, when closing tab is inactive and the active tab is newly created tab,
contents in a tab becomes null.
ie. nothing is displayed, no page source is available, go/back/reload does nothing.
Following message was issued on JavaScript console when this problem occurred.
>Error: newBrowser has no properties
>Source File:
>chrome://global/content/bindings/tabbrowser.xml#tabbrowser.updateCurrentBrowser()
>Line: 6
Problem still occurs on trunc build, Build ID: 2002102704(Win32-ZIP on Win-Me). 

This situation can be cleared by activating another health tab and re-activating
the failed tab.
If closing of inactive tab was done when only 2 tabs are opened, open new tab
and close the new tab is required for recovery.
This case can be reproduced by;
(1) When only 1 tab is opened(TAB-1), open a bookmark to a new tab(TAB-2).
(2) Close TAB-1 from context menu while TAB-1 is inactive.

This problem can be bypassed by activation of target tab(left-click) before
closing the tab.

Comment 6

[Dave]

Sorry about the spam, but is someone gonna review this patch?

Comment 7

[jag (Peter Annema)]

Neil, is this a dupe of bug 173703?

Comment 8

[[e-mail]]

Probably. Also undid your product/target changes, they looked odd.

Comment 9

[[e-mail]]

*** This bug has been marked as a duplicate of 173703 ***