1741453 - Crash in [@ mozilla::gfx::GlyphCacheEntry::Unlink]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

10 Nightly crashes from 3 installations, Linux, macOS, Windows; from bug macOS

Crash report: https://crash-stats.mozilla.org/report/index/201ab7fa-5043-4aad-b298-bf6c20211116

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL mozilla::gfx::GlyphCacheEntry::Unlink dom/canvas/DrawTargetWebgl.cpp:1478
1 XUL mozilla::gfx::GlyphCache::~GlyphCache dom/canvas/DrawTargetWebgl.cpp:1484
2 XUL mozilla::gfx::ReleaseGlyphCache dom/canvas/DrawTargetWebgl.cpp:1489
3 XUL mozilla::gfx::UserData::RemoveAndDestroy gfx/2d/UserData.h:81
4 XUL mozilla::gfx::DrawTargetWebgl::~DrawTargetWebgl dom/canvas/DrawTargetWebgl.cpp:185
5 XUL mozilla::gfx::DrawTargetWebgl::~DrawTargetWebgl dom/canvas/DrawTargetWebgl.cpp:183
6 XUL mozilla::layers::PersistentBufferProviderBasic::~PersistentBufferProviderBasic gfx/layers/PersistentBufferProvider.cpp:32
7 XUL mozilla::layers::PersistentBufferProviderAccelerated::~PersistentBufferProviderAccelerated gfx/layers/PersistentBufferProvider.cpp:105
8 XUL mozilla::dom::CanvasRenderingContext2D::Reset dom/canvas/CanvasRenderingContext2D.cpp:1047
9 XUL mozilla::dom::CanvasRenderingContext2D::ClearTarget dom/canvas/CanvasRenderingContext2D.cpp:1536

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1741453 - Unlink GlyphCacheEntry on failure.

If we fail to rasterize text for a GlyphCacheEntry, it may not have a linked TextureHandle by the time it is destructed.
Check that a handle exists before we try to unlink it. Also, if rasterization fails, just unlink it immediately so we
don't keep around a bunch of empty entries in the glyph cache.

This also fixes some incidental debug assertions that were hit while debugging this - passing rectData on the stack to
the GL, and the mTextureHandles linked list needs to be empty before its destructor is hit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e51d895aa692
Unlink GlyphCacheEntry on failure. r=gfx-reviewers,jrmuizel

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e51d895aa692