1741455 - Update Coc Coc logo

Status: VERIFIED FIXED

(Firefox :: Search, enhancement)

Description

[Romain Testard [:RT]]

Attachment: current.png

Coc Coc is listed as a search engine for our vietnamese build although the logo need updating. I attach the new logo provided by Coc Coc.

Comment 1

[Romain Testard [:RT]]

Attachment: new_logo.png

New logo to be updated

Comment 2

[Romain Testard [:RT]]

Attachment: current.png

I sumbitted the wrong screenshot initially, this one shows the current about:preferences logo that need replacing

Comment 3

[Mark Banner (:standard8)]

Hi Romain, ideally, we need a 32x32 version - this would match the size of the current version. Alternately an svg would probably work.

Comment 4

[Alisa Zhazhieva]

Attachment: Cốc Cốc Search logo.svg

Dear Romain and Mark,

Thank you for updating the logo of Coc Coc Search.
Please, check attached the svg file.

Regards,
Alisa

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Mark Banner (:standard8) from comment #3)

Hi Romain, ideally, we need a 32x32 version - this would match the size of the current version. Alternately an svg would probably work.

We used to enforce .ico with both 32x32 and 16x16 icons, has that changed?

Comment 6

[Alisa Zhazhieva]

Hi Francesco,

Please, help to check .ico with both 32x32 and 16x16 icons attached.
Let me know if need anything.

Thank you

Comment 7

[Alisa Zhazhieva]

Attachment: Cốc Cốc Search logo_16.ico

Comment 8

[Alisa Zhazhieva]

Attachment: Cốc Cốc Search logo_32.ico

Comment 9

[Mark Banner (:standard8)]

Thank you for the new icons. I should be able handle this in the next day or so.

Comment 10

[Mark Banner (:standard8)]

Attachment: Bug 1741455 - Update favicon for Cốc Cốc search engine. r?mkaply!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8308eb3ecad
Update favicon for Cốc Cốc search engine. r=mkaply

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a8308eb3ecad

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 9252160 [details]
Bug 1741455 - Update favicon for Cốc Cốc search engine. r?mkaply!

Beta/Release Uplift Approval Request

• User impact if declined: Users will have out-of-date icon for the Cốc Cốc search engine
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Icon update only
• String changes made/needed: None

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Icon update to reflect the current logo for the search engine.
• User impact if declined: N/A
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Icon change only.
• String or UUID changes made by this patch: None

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9252160 [details]
Bug 1741455 - Update favicon for Cốc Cốc search engine. r?mkaply!

Low risk, approved for 95 beta 12, thanks.

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b7f5fae880c4

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-esr91/rev/c2dcd37536a9

Comment 17

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed on the latest Fx94.4.1ESR, Fx97.0a1 and Fx96.0b10 on Windows 10, Ubuntu 20 and macOS. The new icon is correctly displayed for the Coc Coc engine.

Comment 18

[Mike Kaply [:mkaply]]

So we did desktop builds but not mobile (which was the original image). I'm opening bugs over there, but the image needs to be 96x96 with transparent rounded corners I think.

Comment 19

[Mike Kaply [:mkaply]]

Attachment: Mobile image

Comment 20

[Alisa Zhazhieva]

Attachment: Cốc Cốc Search logo_96x96_white_bevel.png

Hello,

Please, check Cốc Cốc Search logo (96x96 with rounded corners) attached. Let me know if need anything.

Thank you

Comment 21

[Mike Kaply [:mkaply]]

Just to close the loop, new logo was added to both mobile products.