1741493 - Split IPCInternalResponse into three different structs

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Description

[Yaron Tausky [:ytausky]]

Right now IPCInternalResponse contains two streams (body and alternativeBody) each of which can be one of ParentToParentStream, ParentToChildStream or ChildToParentStream. This is problematic due to two reasons:

1. It makes it possible for body and alternativeBody to be different kinds of streams, even though an IPCInternalResponse requires both to be the same kind.
2. Since IPCInternalResponse travels through well-defined code paths that expect specific kinds of streams, it relegates what could be compile-time checks to runtime. This is error prone and results in complicated code.

A possible solution to these concerns is to replace IPCInternalResponse with three distinct structs that differ in the type of streams that they contain.

Comment 1

[Yaron Tausky [:ytausky]]

Attachment: Bug 1741493 - Split IPCInternalResponse r=nika

This commit replaces IPCInternalResponse with three different structs:
ParentToParentInternalResponse, ParentToChildInternalResponse, and
ChildToParentInternalResponse. Doing this let's us convert runtime
checks into compile-time type checks and simplifies relevant code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ed65de569d
Split IPCInternalResponse r=nika

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/63ed65de569d