Closed Bug 1741551 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26192 - Webkit export of https://bugs.webkit.org/show_bug.cgi?id=217414

Categories

(Core :: Performance: General, task, P4)

Product:
Core
Component:
Performance: General
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26192 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26192
Details from upstream follow.

Diego Pino Garcia <dpino@igalia.com> wrote:

Webkit export of https://bugs.webkit.org/show_bug.cgi?id=217414

Sometimes the test fails due to a failed comparison:

Diff: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r268725%20(16529)/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker-actual.txt
@@ -1,5 +1,5 @@

 PASS When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0.
-PASS When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now.
+FAIL When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now. assert_greater_than_equal: expected a number greater than or equal to 36.00000000000001 but got 36
 PASS When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively

To fix the issue I compare values using assert_approx_equals with a margin error of 0.1.

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
FAIL: 6

Chrome

OK : 2
PASS: 6

Safari

OK : 2
PASS: 6

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/user-timing/measure-l3.any.worker.html
When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0.: FAIL
When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now.: FAIL
When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively: FAIL
/user-timing/measure-l3.any.html
When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0.: FAIL
When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now.: FAIL
When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively: FAIL

New Tests That Don't Pass

/user-timing/measure-l3.any.worker.html
When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0.: FAIL (Chrome: PASS, Safari: PASS)
When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now.: FAIL (Chrome: PASS, Safari: PASS)
When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively: FAIL (Chrome: PASS, Safari: PASS)
/user-timing/measure-l3.any.html
When the end mark is given and the start is unprovided, the end time of the measure entry should be the end mark's time, the start time should be 0.: FAIL (Chrome: PASS, Safari: PASS)
When the start mark is given and the end is unprovided, the start time of the measure entry should be the start mark's time, the end should be now.: FAIL (Chrome: PASS, Safari: PASS)
When start and end mark are both given, the start time and end time of the measure entry should be the the marks' time, repectively: FAIL (Chrome: PASS, Safari: PASS)

https://hg.mozilla.org/mozilla-central/rev/c6a20f9cbdf3

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.