Closed Bug 1741560 Opened 2 years ago Closed 2 years ago

Unhelpful error message in case of unsigned add-on being installed via policy, but signing required

Categories

(Firefox :: Enterprise Policies, defect)

Product:
Firefox
Component:
Enterprise Policies
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: TbSync, Assigned: mkaply)

References

Details

Attachments

(1 file)

Bug 1741560 - Handle unsigned XPI case in policy. r?john.bieling
48 bytes, text/x-phabricator-request
Details | Review

Policies.jsm fails to detect if the add-on being installed by policy fails because of not being signed, even though that is required. It fails with an unhelpful error message here:

https://searchfox.org/mozilla-central/rev/df18dd52da04ee2bad434b0ba2d9fcb196d4d15e/browser/components/enterprisepolicies/Policies.jsm#2442

TypeError: can't access property "id", install.addon is null

Blocks: 1741561

Do you want me to try to come up with a patch, or do you want to handle it yourself?

Flags: needinfo?(mozilla)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED

Thanks for the offer. I went ahead and did it because I was curious if there were any other issues. I think this catches things correctly.

The error that ends up showing (from policy) is:

Download failed - ERROR_SIGNEDSTATE_REQUIRED - file:///c:/users/mike/downloads/foo.xpi

Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/43937ff9cf28
Handle unsigned XPI case in policy. r=john.bieling

https://hg.mozilla.org/mozilla-central/rev/43937ff9cf28

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
QA Whiteboard: [qa-96b-p2]
You need to log in before you can comment on or make changes to this bug.