1741597 - dFPI rollout pref set to false should not always set cookie behavior to BEHAVIOR_REJECT_TRACKER

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Emma Zühlcke [:emz]]

Setting privacy.restrict3rdpartystorage.rollout.enabledByDefault to false explicitly will always set cookie behavior to BEHAVIOR_REJECT_TRACKER. This is unexpected for release channels which have a different default cookie behavior.
Instead we should revert the cookie behavior to its initial default value.

https://searchfox.org/mozilla-central/rev/df18dd52da04ee2bad434b0ba2d9fcb196d4d15e/browser/components/BrowserGlue.jsm#1757

Comment 1

[Emma Zühlcke [:emz]]

This behavior isn't problematic for now, since Beta and Release use BEHAVIOR_REJECT_TRACKER as the default. However, we should keep it in mind when we want to switch over to BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN by default. In that case opted-out users would get BEHAVIOR_REJECT_TRACKER.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1741597 - Revert cookie behavior to initial default value when dFPI rollout pref is set to false. r=timhuang!

Comment 3

[Tim Huang[:timhuang]]

Feel free to raise up the priority if you feel needed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40580eaf2289
Revert cookie behavior to initial default value when dFPI rollout pref is set to false. r=timhuang

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in browser_contentblocking_standard_tcp_toggle

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e4fb69d25c44a6b06cba30c86fb6bf1ce068c95

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429acbc4647f
Revert cookie behavior to initial default value when dFPI rollout pref is set to false. r=timhuang

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/429acbc4647f

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emma Zühlcke [:emz]]

Comment on attachment 9251118 [details]
Bug 1741597 - Revert cookie behavior to initial default value when dFPI rollout pref is set to false. r=timhuang!

Beta/Release Uplift Approval Request

• User impact if declined: This is part of the TCP / dFPI rollout. This bug impairs the rollout for specific users. If we want to switch users over to have dFPI enabled by default, but they still have an opt-out choice stored in their profile from the experiment, they'll not be switched over to dFPI until we remove the experiment / opt-in code.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On Nightly:

1. Go to about:config and verify network.cookie.cookieBehavior is set to 5 initially
2. Add a bool pref privacy.restrict3rdpartystorage.rollout.enabledByDefault and set it to true. => network.cookie.cookieBehavior is still set to 5
3. Update privacy.restrict3rdpartystorage.rollout.enabledByDefault to false => network.cookie.cookieBehavior is still set to 5

On Beta:

1. Go to about:config and verify network.cookie.cookieBehavior is set to 4 initially
2. Add a bool pref privacy.restrict3rdpartystorage.rollout.enabledByDefault and set it to true. => network.cookie.cookieBehavior has changed to 5
3. Update privacy.restrict3rdpartystorage.rollout.enabledByDefault to false => network.cookie.cookieBehavior is back on 4

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small code change with good test coverage.
• String changes made/needed:

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9251118 [details]
Bug 1741597 - Revert cookie behavior to initial default value when dFPI rollout pref is set to false. r=timhuang!

Approved for 100.0b8

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d95381f41cd

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 100.0b8 (64-bit) as well as our latest Nightly 101.0a1 (2022-04-19).