1741669 - Implement a faster version for getParentTarget

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

TargetMixin.getFront:
https://searchfox.org/mozilla-central/rev/df18dd52da04ee2bad434b0ba2d9fcb196d4d15e/devtools/client/fronts/targets/target-mixin.js#202-224
is a bit obsolete with the end of the method no longer used.
Also it depends on doing one RDP request whereas we could avoid that by passing some extra data in target's form.

The goals was originaly to also make this method synchronous, but because of backward compat this is harder than expected.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1741669 - [devtools] Implement a faster TargetCommand.getParentTarget.

The original intent was to do a synchronous implementation,
but this is hard to do while keeping backward compat.

Comment 2

[Alexandre Poirot [:ochameau]]

It looks like try is green now:
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=RJiQnt1uQruk-YT3VjrTEg.0&revision=d4e38aa035b6fd935c3b742840fbb4bccd01fa74

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86e47c8c9ce8
[devtools] Implement a faster TargetCommand.getParentTarget. r=nchevobbe

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86e47c8c9ce8