Closed Bug 1741691 Opened 4 years ago Closed 4 years ago

Bookmark editor don't display for local files

Categories

(Firefox :: Bookmarks & History, defect)

Firefox 91
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: Boomerang_Aide, Unassigned)

Details

Steps to reproduce:

  1. Open a local html file (url starting with file:///)
    2a. Try to bookmark it by clicking the context menu entry or the "bookmark current tab" in the bookmark top menu
    2b. Try to edit the bookmark by clicking the context menu entry or the "edit bookmark" in the bookmark top menu

Actual results:

3a. The page is bookmarked instantly without displaying the popup editor to set the details of the page
3b. Nothing happen. The popup editor don't display at all.

Expected results:

A popup editor should have appeared to choose the name and location of the bookmark, like it would on normal web pages.

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

Hi,

I wasn't able to reproduce this issue on my end using Firefox 94 or Firefox Nightly 96.0a1.

Could you try if it also occurs to you while using a new profile? (you won't lose your current profile)
Here is a link that can help:
https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles#w_start-the-profile-manager-when-firefox-is-closed

Thank you!

Flags: needinfo?(Boomerang_Aide)

Thank you for your feedback.
I checked thoroughly, and identified the side of the issue caused by me:
A piece of code in userChrome.css to hide the star in the urlbar:

#star-button-box {
  display: none !important;
}

Using visibility: collapse !important; produces the same result (no popup).

While it's true that the piece of code that started it came from me, it's weird that that element is required and required only for offline files.
So there may really be a bug to fix there.

Flags: needinfo?(Boomerang_Aide)

Thank you for finding where the issue was. As this is userChrome.css related marking as works for me. As everything is working without the userChrome.css, I'm inclined to say that we won't look at it any further at this time as we have other higher priority items to work on.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.