Closed Bug 1741771 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31669 - [FlexNG] Adjust flexbox info for item expansion

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31669 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31669
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Adjust flexbox info for item expansion

When a flex-item expands due to fragmentation, we need to adjust the
intrinsic-block-size and subsequent offsets.

To accomplish this, store the original block-size of each item on
NGFlexItem, and reduce the original block-size as the item is
fragmented. If this block-size becomes negative, we know the item
expanded as a result of fragmentation.

This expansion is then accumulated within the NGFlexLine where it
can be used to adjust the offsets of subsequent items.

LayoutWithBlockFragmentation() was also removed, and its logic
was moved into GiveItemsFinalPositionAndSizeForFragmentation() for
convenience.

Bug: 660611
Change-Id: I67524cd436a87aebd52382682b2cea9d9d32b018
Reviewed-on: https://chromium-review.googlesource.com/3290486
WPT-Export-Revision: e37d8f29140150102abfcad4334a96e5002e32f8

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 1
FAIL: 5

Chrome

PASS: 4
FAIL: 2

Safari

PASS: 4
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/single-line-column-flex-fragmentation-009.html: FAIL
/css/css-break/flexbox/single-line-column-flex-fragmentation-010.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/single-line-column-flex-fragmentation-009.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-010.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-012.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-013.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-break/flexbox/single-line-column-flex-fragmentation-014.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c52cd776e3a8
[wpt PR 31669] - [FlexNG] Adjust flexbox info for item expansion, a=testonly
https://hg.mozilla.org/integration/autoland/rev/57edb22488d6
[wpt PR 31669] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.