1741793 - Cache text selection

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

We need to cache text selection ranges in the parent process cache.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1741793 part 1: Remove TextRange stuff that was never implemented.

This class needs to be updated to support base Accessible and it doesn't make sense to port methods that can never be used.
Also, any new functionality (e.g. needed for the UIA text pattern) should now be implemented using TextLeafPoint/Range, not TextRange.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1741793 part 2: Update TextPoint/Range to use base Accessible.

Even though we'd ideally be using TextLeafRange for new things, TextRange is still needed by our selection events (which still use HyperText offsets) and IA2/ATK clients which depend on HyperText offsets.
Thus, we need TextRange to support RemoteAccessible.

Although the start and end containers are HyperTextAccessibles, I chose to store Accessible rather than HyperTextAccessibleBase because HyperTextAccessibleBase doesn't inherit from Accessible and having an Accessible is easier.

XPCOM needs to hold a reference to any state objects.
Because we can't hold a reference to an Accessible (due to RemoteAccessible), xpcAccessibleTextRange holds references to xpcAccessibleHyperText instead.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1741793 part 3: Cache text selection in the parent process.

This uses selection changed and caret moved events.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1741793 part 4: Implement text selection querying for cached RemoteAccessible.

The original non-Windows RemoteAccessible SelectionBoundsAt method still exists because it allows the caller to retrieve both the offsets and the text in a single call, which can't be done with the unified API.
Thus, platform code still needs a separate code path for non-cached RemoteAccessible.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1741793 part 5: Update XPCOM, Windows and ATK to support cached text selection querying.

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1741793 part 6: Add tests to exercise RemoteAccessible text selection retrieval.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46f519715bb
part 1: Remove TextRange stuff that was never implemented. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/9b08846e5ee3
part 2: Update TextPoint/Range to use base Accessible. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/65397920b811
part 3: Cache text selection in the parent process. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/639172abb542
part 4: Implement text selection querying for cached RemoteAccessible. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/364cf24d2689
part 5: Update XPCOM, Windows and ATK to support cached text selection querying. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/c817b1fb4e22
part 6: Add tests to exercise RemoteAccessible text selection retrieval. r=eeejay

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e46f519715bb
https://hg.mozilla.org/mozilla-central/rev/9b08846e5ee3
https://hg.mozilla.org/mozilla-central/rev/65397920b811
https://hg.mozilla.org/mozilla-central/rev/639172abb542
https://hg.mozilla.org/mozilla-central/rev/364cf24d2689
https://hg.mozilla.org/mozilla-central/rev/c817b1fb4e22