1741815 - Titles on tabs are barely visible if the browser is focused while light theme is set and the High contrast white enabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: tabs not visible.gif

Affected versions

• Nightly 96.a1
• Beta 95.0b8

Affected platforms

• Windows 10x64

Preconditions

• High contrast white enabled at OS level.

Steps to reproduce

1. Open a Firefox with a clean profile.

2. Have at least 2-3 tabs opened.

3. Enable Light theme from about:addons.

4. Observe the tabs title.

Expected result

• All open tabs are visible.

Actual result

• Only the focused tab is visible.

Suggested Severity

• S3 - since is reproducible only with high contrast enabled.

Regression range

• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1a071728a13b36aeda3b1c65f9ab3285e4299175&tochange=b74995b8a309c269eee1dd8e3b54c02bc42d6a38

Additional notes

• Screen cast attached to observe the issue.
• Titles on tabs are visible if the browser is unfocused.
• Also reproducible with High contrast Black and Light theme enabled.

Comment 1

[Giorgia Nichita, Release Desktop QA]

@Emilio, it seems that Bug 1715990 caused the regression, can you please have a look at this?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1715990

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741815 - Don't override lightweight theme colors in HCM. r=#desktop-theme-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2e3a0b6b0e4
Don't override lightweight theme colors in HCM. r=desktop-theme-reviewers,dao

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2e3a0b6b0e4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9251356 [details]
Bug 1741815 - Don't override lightweight theme colors in HCM. r=#desktop-theme-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix for non-system-theme + HCM.
• String changes made/needed: none

Comment 8

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on 96.0a1 (20211122093912) Windows 10x64, using both High Contrast White and HC Black.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9251356 [details]
Bug 1741815 - Don't override lightweight theme colors in HCM. r=#desktop-theme-reviewers

Low risk CSS fix verified in Nightly, approved for 95 beta 11, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bb0a1b7c2a45

Comment 11

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Windows 10x64, Beta 95.0b11 (20211123190150). All open tabs are visible. Thanks!