1741861 - Move the _subscribeEvent logic fully to the root/session.jsm module

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Julian Descottes [:jdescottes]]

At the moment we implement a _subscribeEvent command in the ROOT log.jsm module in order to check if the event names passed to session.subscribe are supported.

Instead, if the log module exposes the list of events it supports, this logic could be fully moved to the session.subscribe command, which will avoid code duplication when we start supporting events on other modules.

Comment 1

[Julian Descottes [:jdescottes]]

As discussed in https://phabricator.services.mozilla.com/D128284#inline-723314 we can also add shared methods to handle events in the abstract Module.jsm class.

Comment 2

[Julian Descottes [:jdescottes]]

Should work on this when implement another module with events, eg Bug 1694389

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Before working on this bug it would be good to have a second event implemented in a module.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1741861 - Move shared logic from _subscribeEvent and _unsubscribeEvent. r=jdescottes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1acf89b996d9
Move shared logic from _subscribeEvent and _unsubscribeEvent. r=webdriver-reviewers,jdescottes

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1acf89b996d9