Closed Bug 1741868 Opened 6 months ago Closed 6 months ago

Add a scorer for scoring snapshots based on a relevancy score

Categories

(Firefox :: Bookmarks & History, task, P2)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

We want to add a scorer for snapshots so that we can assess them based on a relevancy score so that we can provide better results via snapshot selectors.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90063a429c82
Add a scorer for scoring snapshots based on a relevancy score. r=mossop
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Regressions: 1742152

Backed out for causing almost perma assertion failures on GMPServiceParent.cpp

[task 2021-11-24T23:51:30.544Z] 23:51:30     INFO -  PID 8892 | Assertion failure: mShuttingDown, at /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:291
[task 2021-11-24T23:51:30.544Z] 23:51:30     INFO -  PID 8892 | Destroying context 000001EAD0A6E000 surface 000001EAD0261D60 on display 000001EAD0A04C00
[task 2021-11-24T23:51:30.545Z] 23:51:30     INFO -  PID 8892 | [GPU 816, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4439
[task 2021-11-24T23:51:30.545Z] 23:51:30     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2021-11-24T23:51:40.666Z] 23:51:40     INFO -  PID 8892 | #01: mozilla::gmp::GeckoMediaPluginServiceParent::Observe(nsISupports*, char const*, char16_t const*) [dom/media/gmp/GMPServiceParent.cpp:291]
[task 2021-11-24T23:51:40.673Z] 23:51:40     INFO -  PID 8892 | #02: nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverList.cpp:69]
[task 2021-11-24T23:51:40.673Z] 23:51:40     INFO -  PID 8892 | #03: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverService.cpp:295]
[task 2021-11-24T23:51:40.674Z] 23:51:40     INFO -  PID 8892 | #04: mozilla::AdvanceShutdownPhaseInternal(mozilla::ShutdownPhase, bool, char16_t const*, nsCOMPtr<nsISupports> const&) [xpcom/base/AppShutdown.cpp:362]
[task 2021-11-24T23:51:40.674Z] 23:51:40     INFO -  PID 8892 | #05: mozilla::ShutdownXPCOM(nsIServiceManager*) [xpcom/build/XPCOMInit.cpp:624]
[task 2021-11-24T23:51:40.674Z] 23:51:40     INFO -  PID 8892 | #06: XRE_XPCShellMain(int, char**, char**, XREShellData const*) [js/xpconnect/src/XPCShellImpl.cpp:1434]
[task 2021-11-24T23:51:40.718Z] 23:51:40     INFO -  PID 8892 | #07: NS_internal_main(int, char**, char**) [js/xpconnect/shell/xpcshell.cpp:82]
[task 2021-11-24T23:51:40.723Z] 23:51:40     INFO -  PID 8892 | #08: wmain(int, wchar_t**) [toolkit/xre/nsWindowsWMain.cpp:147]
[task 2021-11-24T23:51:40.723Z] 23:51:40     INFO -  PID 8892 | #09: __scrt_common_main_seh() [/builds/worker/workspace/obj-build/js/xpconnect/shell/d:/agent/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl:288]
[task 2021-11-24T23:51:40.725Z] 23:51:40     INFO -  fix-stacks: error: failed to read debug info file `wkernel32.pdb` for `C:\Windows\System32\KERNEL32.DLL`
[task 2021-11-24T23:51:40.726Z] 23:51:40     INFO -  fix-stacks: note: this is expected and harmless for all PDB files on opt automation runs
[task 2021-11-24T23:51:40.726Z] 23:51:40     INFO -  fix-stacks: The system cannot find the file specified. (os error 2)
[task 2021-11-24T23:51:40.727Z] 23:51:40     INFO -  PID 8892 | #10: BaseThreadInitThunk [C:\Windows\System32\KERNEL32.DLL + 0x17034]
[task 2021-11-24T23:51:40.730Z] 23:51:40     INFO -  fix-stacks: error: failed to read debug info file `wntdll.pdb` for `C:\Windows\SYSTEM32\ntdll.dll`
[task 2021-11-24T23:51:40.730Z] 23:51:40     INFO -  fix-stacks: note: this is expected and harmless for all PDB files on opt automation runs
[task 2021-11-24T23:51:40.731Z] 23:51:40     INFO -  fix-stacks: The system cannot find the file specified. (os error 2)
[task 2021-11-24T23:51:40.731Z] 23:51:40     INFO -  PID 8892 | #11: RtlUserThreadStart [C:\Windows\SYSTEM32\ntdll.dll + 0x52651]
[task 2021-11-24T23:51:40.731Z] 23:51:40     INFO -  <<<<<<<

Seeing as it turned into an almost permafail [tier 1] with a rate of 9 failures out of 11 retriggers, we backed it out.

Status: RESOLVED → REOPENED
Flags: needinfo?(standard8)
Resolution: FIXED → ---
Target Milestone: 96 Branch → ---
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe03fc348694
Add a scorer for scoring snapshots based on a relevancy score. r=mossop
Depends on: 1742963
Flags: needinfo?(standard8)
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.