1741900 - First window titlebar is not dark anymore

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1734359 has regressed for the first window by bug 1736141, because LookAndFeel hasn't initialized sChromeColorScheme by the time it's queried.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741900 - Make nsLookAndFeel init deterministic, and add asserts to prevent reading zero-initialized static variables. r=cmartin,mhowell,mstange

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1736141

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Emilio, are you landing this bug?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741900 - Ensure color-scheme is initialized in a couple callers which might not have initialized LookAndFeel yet. r=mstange,mhowell

The previous patch would be a better fix, but it causes some xpcshell
crashes on Linux which I haven't figured out yet (because initializing
LookAndFeel initializes gfxPlatform).

This should be less risky and still fix the bug.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

See above

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e828ea8e494
Ensure color-scheme is initialized in a couple callers which might not have initialized LookAndFeel yet. r=mhowell

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9e828ea8e494

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9252286 [details]
Bug 1741900 - Ensure color-scheme is initialized in a couple callers which might not have initialized LookAndFeel yet. r=mstange,mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Minor cosmetic issue, but very simple fix in the end.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very trivial fix to avoid computing color-scheme too late.
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9252286 [details]
Bug 1741900 - Ensure color-scheme is initialized in a couple callers which might not have initialized LookAndFeel yet. r=mstange,mhowell

We have no beta left and already merged mozila-beta to mozilla-release, I think this ship with 96.

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 96.0a1 (2021.11.19) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 96.0a1 (latest nightly from 2021.12.06) on Win 10 x64, macOS 10.15 and Ubuntu 20.04 x64.

Comment 12

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Verified on 96.0b1 on Ubuntu 20.04 and on macOS 10.15 the issue is fixed, but on Windows 10 x64 the first window title bar dark theme was applied only after a Firefox restart. On latest nightly 97.0a1 the problem is the same, only after a Firefox restart the dark title bar was applied. Changing the theme to a light theme the title bar remain dark, only after a restart was changed to light.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Yeah, it seems windows is not great at reacting to dynamic changes to this setting , so not great, but also not much we can do about it I think.

Comment 14

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Based on the above comment, I will take out the qe-verify+ flag.