1741908 - ensure abuse reports work with sitepermission addons

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1741908 - Move list of the addon types supported by the abuse reports into a single place. r?mixedpuppy!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1741908 - Add support for abuse reporting to the sitepermission addon type. r=mixedpuppy!

TODO: to support abuse reports for the sitepermission addon type, we will have to:

• [x] confirm if any of the abuse categories below should be hidden (e.g. like some are hidden for themes):
  • agreed to keep damage, broken, unwanted and other
• [x] confirm if any of the existing strings associated to the abuse categories we will support have to be reworded (e.g. for themes some are)
  • some had to be reworded a little bit, see changes to the Fluent file in this patch.
• [x] create new l10n entries for the '*-sitepermission' strings (like for themes and extension, see:
  https://searchfox.org/mozilla-central/search?q=-extension&path=abuseReports.ftl )
• [x] confirm using addon.siteOrigin as the preferred support URL (included in the suggestion
  for the "broken" category, in the second screen after the category has been selected)
  • in the current version of this patch siteOrigin is going to be used as a fallback if no
    homepage_url or support url was explicitly specified
• [ ] extend the existing tests to also cover the sitepermission addon type
  • [x] add a test case to cover all suggestions fluent strings
  • [ ] add one more test case to test the fallback to siteOrigin on no homepage_url in the manifest
  • [ ] make sure to cover also the fluent strings for the message bars (which also cover the completed submission)

Depends on D132396

Comment 3

[Shane Caraveo (:mixedpuppy)]

Lets keep damage, broken, unwanted and other, all with the same wording. Wording can be tweaked in future versions (eg. next time we add a site permission).

Comment 4

[Shane Caraveo (:mixedpuppy)]

reasons:

damage: some apis may provided access to system level resources
spam: the addon cannot insert stuff so hide it
settings: the addon cannot change settings, it only provides a permission for a given dom api, hide it
deceptive: on the fence, but since it can only provide a permission to a site, we'll hide it for now
broken: a user could perceive this is breaking something, so lets leave it visible
policy: the addon cannot contain anything, so hide this
unwanted: I don't see a reason to hide this even for themes, lets leave it visiable for site permissions
other: never hide

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: SitePermAbuseReportScreen01 from 2021-11-29 21-28-35.png

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: SitePermAbuseReportScreen02 from 2021-11-29 21-53-25.png

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: SitePermAbuseReportScreen01 from 2021-11-30 00-21-27.png

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: SitePermAbuseReportScreen02 from 2021-11-30 00-22-18.png

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9750807dbef
Move list of the addon types supported by the abuse reports into a single place. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/e5d02853985c
Add support for abuse reporting to the sitepermission addon type. r=mixedpuppy,fluent-reviewers

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f9750807dbef
https://hg.mozilla.org/mozilla-central/rev/e5d02853985c

Comment 11

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1741908 pluralize string for site permissions abuse reporting

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28cffb1d6be7
pluralize string for site permissions abuse reporting r=flod,fluent-reviewers

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/28cffb1d6be7