Closed Bug 1741921 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 31677 - [Fixit] Take the creator's secure context bit into account for workers.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 31677 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31677
Details from upstream follow.

Titouan Rigoudy <titouan@chromium.org> wrote:

[Fixit] Take the creator's secure context bit into account for workers.

Previously, it was implicitly assumed that the creator was a secure
context iff the worker or worklet was a secure context.

This also affects worklets, but those can only be created by secure
contexts, so this change is a no-op in that case.

Shared workers are also not affected by this change, because they
incorrectly compute the secure context bit of their creator based on
the origin. This change adds a TODO to fix that in a follow-up.

This change is gated behind a runtime-enabled feature flag until the
UseCounter data tells us whether this would have a large impact or not.

Bug: chromium:780031
Change-Id: I062f289d34aed8e0a8adf930b44825a237ad7582
Reviewed-on: https://chromium-review.googlesource.com/3288993
WPT-Export-Revision: cff2527b68ab2e1dde66c3268ee0c379b5042fc1

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Whiteboard: [wptsync downstream] → [wptsync downstream error]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 6

Chrome

OK : 1
PASS: 5
FAIL: 1

Safari

OK : 1
PASS: 4
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/646ae9a5ce6b [wpt PR 31677] - [Fixit] Take the creator's secure context bit into account for workers., a=testonly
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.