1742010 - File descriptor leak when serializing into SurfaceDescriptorAndroidHardwareBuffer

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

https://searchfox.org/mozilla-central/rev/3881c4ca80d1b4b2f43be695438ecaf90ee4f86c/gfx/layers/opengl/TextureClientOGL.cpp#271
https://searchfox.org/mozilla-central/rev/3881c4ca80d1b4b2f43be695438ecaf90ee4f86c/gfx/layers/client/TextureClientSharedSurface.cpp#87

There is a footgun with ipc::FileDescriptor(readerFd.release()) where we pass a raw file descriptor due to the release() call. The constructor chosen actually dups the file handle, requiring us to free our own:

https://searchfox.org/mozilla-central/rev/3881c4ca80d1b4b2f43be695438ecaf90ee4f86c/ipc/glue/FileDescriptor.cpp#33

We should just do a move to avoid this.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1742010 - File descriptor leak when serializing into SurfaceDescriptorAndroidHardwareBuffer.

We accidently duplicate the file descriptor when serializing because we
hit a constructor for ipc::FileDescriptor which duplicates the handle
instead of just taking it. This means we are supposed to close it
explicitly but we've already forgotten about it. We should just do a
move instead to avoid this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b6abfc76fd5
File descriptor leak when serializing into SurfaceDescriptorAndroidHardwareBuffer. r=sotaro,gfx-reviewers

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9b6abfc76fd5