Closed Bug 1742084 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 31681 - Automatically detect Chrome browser binary if it exists

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31681 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31681
Details from upstream follow.

Daniel Smith <smithdr92@gmail.com> wrote:

Automatically detect Chrome browser binary if it exists

The current implementation of the Chrome class does not check the specified venv path for an existing Chrome browser binary. Additionally, the current implementation will not fall back to other possible binary paths if the nightly channel is specified but no binary is found in the venv path. This change will allow ./wpt run chrome commands to run without explicitly specifying the --binary flag.

@foolip Maybe you know if this hurts any intended behavior? The only thing I can think of is if the nightly binary MUST be found and we should not try to find other binaries on the machine.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ce824b75205
[wpt PR 31681] - Automatically detect Chrome browser binary if it exists, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/3ce824b75205

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.