Closed Bug 1742089 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31682 - Avoid SetAnimationStyleChange(true) without a ComputedStyle

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31682 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31682
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

Avoid SetAnimationStyleChange(true) without a ComputedStyle

If the IsAnimationStyleChange is true, then CSSAnimations::
CalculateAnimationUpdate expects any CSS animations defined by the base
style to actually be present in |running_animations_|. However, this
will not be the case for elements with ShouldStoreComputedStyle()=false,
since any pending animation updates are canceled in Element::
RecalcOwnStyle if we ultimately don't want to store the newly
produced ComputedStyle.

Fixed: 1264236
Change-Id: I07dbdfe861de33f1d29e973b2fe6b5daf9b530c7
Reviewed-on: https://chromium-review.googlesource.com/3291749
WPT-Export-Revision: ec3858a7f99a3dd8d9ee691ef151a28ff7bdec5b

Component: web-platform-tests → SVG
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68ec848a4191
[wpt PR 31682] - Avoid SetAnimationStyleChange(true) without a ComputedStyle, a=testonly
You need to log in before you can comment on or make changes to this bug.