Closed Bug 1742166 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 31689 - Fix SameSite WPT window.open() tests

Categories

(Core :: Networking: Cookies, task, P4)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31689 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31689
Details from upstream follow.

Steven Bingler <bingler@chromium.org> wrote:

Fix SameSite WPT window.open() tests

These two tests had a typo in which the origin was used as the start
and the target of the test navigations. The target argument was unused.

This CL corrects that and updates the expected results for a couple
affected tests. (Plus some comments changes.)

Change-Id: I913f927c755ef21f2c6632bc84fca7b624a894a8

Reviewed-on: https://chromium-review.googlesource.com/3290927
WPT-Export-Revision: b7257f67c27c066fc470a883dfad30d86f348a83

Component: web-platform-tests → Networking: Cookies
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 12 subtests

Status Summary

Firefox

OK : 2
PASS: 14
FAIL: 1

Chrome

OK : 2
PASS: 15

Safari

OK : 2
PASS: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/cookies/samesite/window-open-reload.https.html
Reloaded cross-site auxiliary navigations are strictly same-site: FAIL

New Tests That Don't Pass

/cookies/samesite/window-open-reload.https.html
Reloaded cross-site auxiliary navigations are strictly same-site: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb7d9c6a7f9a
[wpt PR 31689] - Fix SameSite WPT window.open() tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b112d0625e0d
[wpt PR 31689] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.