Implement packetsDiscarded/discardedPackets for inbound-rtp
Categories
(Core :: WebRTC, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
(Blocks 3 open bugs)
Details
Attachments
(3 files)
Until bug 1654112 we supported discardedPackets for video inbound-rtp stats. Bring that back to avoid a regression in 96.
Upstream has with the new update implemented it for audio and removed it for video, and the spec has changed from discardedPackets to packetsDiscarded.
I aim to implement packetsDiscarded for audio and video, and bring back discardedPackets for video unless a stats peer thinks otherwise. There is bug 1335967 that has not landed..
Support for the bookkeeping of discarded packets will have to be added upstream. I plan to land locally first and do uplift later since we are on a schedule.
|
Assignee | |
Comment 1•2 years ago
|
||
This cherry-picks the applicable parts of:
https://webrtc.googlesource.com/src/+/28a2c63526f471558bc93cdcae9fab42b84b10a5
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D131707
|
|
Assignee | |
Comment 3•2 years ago
|
||
This also brings back discardedPackets for video, to avoid a regression.
Depends on D131708
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/654bb10e1616 Cherry-pick libwebrtc patch for audio recv stat packetsDiscarded. r=ng https://hg.mozilla.org/integration/autoland/rev/d0196a45a1f4 libwebrtc: Implement packetsDiscarded bookkeeping for received video. r=ng https://hg.mozilla.org/integration/autoland/rev/a689bb41ea69 Pipe through the packetsDiscarded stat for inbound-rtp. r=ng,jib
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/654bb10e1616
https://hg.mozilla.org/mozilla-central/rev/d0196a45a1f4
https://hg.mozilla.org/mozilla-central/rev/a689bb41ea69
Description
•