1742229 - Firefox doesn't use modifiers for YUV surfaces

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Stephen]

Attachment: use-modifiers-for-yuv.patch

Steps to reproduce:

I'm attempting to get Firefox working with my new VA-API implementation that uses NVIDIA's NVDecode.

Actual results:

I just got a green box instead of the video.

Expected results:

The video should have shown.

I managed to fix the issue by getting Firefox to set the modifiers for YUV surfaces aswell as for RGBA surfaces. I've attached a patch.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Hello Stephen,
thanks for the patch, do you mind to use phabricator to submit it?
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Thanks.

Comment 2

[Stephen]

Attachment: Bug 1742229 - Firefox doesn't use modifiers for YUV surfaces r?stransky

Firefox is not setting the modifiers for YUV surfaces causing the import of surfaces that require them to fail.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Stephen, the patch is in 'draft / Changes Planned' state. Is that correct?
Thanks.

Comment 4

[Stephen]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #3)

Stephen, the patch is in 'draft / Changes Planned' state. Is that correct?
Thanks.

No the patch is complete, but I'm not certain what I need to do to get it out of that state.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Please try to submit the patch again. Remove WIP: prefix and add r?stransky at the end. That should move the patch to review queue.
Thanks.

Comment 6

[Stephen]

Done

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Great, Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dd4b8501129
Firefox doesn't use modifiers for YUV surfaces r=stransky

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Stephen,

do you mind to provide any details how VA-API with NVIDIA drivers can be used? Right now we're missing any info how to set up (and I don't have any NVIDIA hardware):

https://fedoraproject.org/wiki/Firefox_Hardware_acceleration#Video_decoding_on_NVIDIA

Thanks.

Comment 10

[Stephen]

To use VA-API with NVIDIA with DMA-BUF support, you need the new VA-API implementation I've been developing, not the VDPAU one that's currently available. I haven't released the source code for this yet, but I do plan to.

I'm somewhat hesitant to do so at the moment as Firefox is really the only use case for it (most other apps will just use NVDEC directly), and there are other blockers, such as needing to completely disable the sandbox for it to run (it needs cuda and a gstreamer lib).

However, once there's a version of Firefox available that only needs config/environment variables to use it, rather than a custom build that'll make it much easier to test and will make a good point to release the code.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

I see, Thanks for the info.

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9dd4b8501129

Comment 13

[Darkspirit]

It would be interesting if this works on Nvidia as well: https://www.phoronix.com/scan.php?page=news_item&px=VA-API-On-Vulkan-Video-Hacks