1742239 - [Light Theme] Regression: Shadow around selected tab is too dark again

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Mehmet]

Attachment: Border_around_active_tab_Light_Theme.png

After fixing bug 1738855 and bug 1740788, the border around the active tab in Light Theme is again too dark and doesn't match other separtors like e.g. the toolbar border.

I think the dark border was initially fixed for Light Theme with bug 1740788 and bug 1740788 could have regressed it again?

Screenshots actual vs ecpected are attached.

OS: macOS 12.0.1
Nightly 96.0a1 (2021-11-20) (64-Bit)

Thanks for checking and fixing it in advance.

Comment 1

[Mehmet]

+Dão and +Amy because of bug 1738855 and bug 1740788. Thanks for checking.

Comment 2

[Sören Hentzschel]

To copy one part of my comment from bug 1738855 (I wasn't aware of this new ticket when I wrote that comment):

And since it's darker the clipped shadow (on the left side; a pre-existing issue) is much more noticeable.

It's also something to take into consideration.

Comment 3

[Mehmet]

Attachment: Clipping_right_side.png

(In reply to Sören Hentzschel from comment #2)

To copy one part of my comment from bug 1738855 (I wasn't aware of this new ticket when I wrote that comment):

And since it's darker the clipped shadow (on the left side; a pre-existing issue) is much more noticeable.

It's also something to take into consideration.

Maybe the shadow clipping is caused by the invisible Tab Bar Scroll divider/arrow? The shadow clipping appears also on the right side at the very right tab, when Tab Bar scrolling is possible. Please see the attached screenshot. Is there already a bug report for it? If not, I can open one. Just let me know it. Thanks.

Comment 4

[Mehmet]

Attachment: Example_Cheers_Soft_Theme_Dark_Border_Shadow.png

The darker border/shadow also affects all other themes with a focused light tab. E.g. the new delivered Cheers Soft Theme. (Please see the attached screenshot.)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1742239 - Reduce opacity of the selected tab's box-shadow. r=harry

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93e90c717488
Reduce opacity of the selected tab's box-shadow. r=harry

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/93e90c717488

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9255247 [details]
Bug 1742239 - Reduce opacity of the selected tab's box-shadow. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Can be verified with any light-colored theme
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial one-line CSS fix
• String changes made/needed:

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9255247 [details]
Bug 1742239 - Reduce opacity of the selected tab's box-shadow. r=harry

Approved for 96.0b7

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d3a86f3d462

Comment 12

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04 x64.

Comment 13

[Mehmet]

Hi, maybe you can take a look at Bug 1747791 ? There is a regression of the tab's box-shadow, when the window is in the background. Many thanks in advance.