174225 - make NS_IMPL_OWNINGTHREAD (and NS_INIT_ISUPPORTS) unnecessary

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a followup to bug 166147.  If we make NS_IMPL_OWNINGTHREAD (the debug
code for our threadsafety warnings) based on a class with a constructor, we can
make NS_IMPL_ISUPPORTS unnecessary and just remove it.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This isn't tested yet, since my build is only part of the way through.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I've tested that the assertions still work by removing some "THREADSAFE_" in
places that need it in my tree, and seeing that assertions do fire.

Also, in comment 0, I meant NS_INIT_ISUPPORTS rather than NS_IMPL_ISUPPORTS.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 102723 [details] [diff] [review]
patch

I am not sure that we should mark NS_INIT_ISUPPORTS deprecated or suggest that
developers not use this macro.	This reason, although minor, is that it allows
us to hook into  xpcom object constructors quite easily.  For example, a bloat
too could redefine this macro to do something. 

Thoughts?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Anybody else who wants to hook in can just use the same method that this uses
and that the refcount uses (bug 166147) -- hook in via NS_DECL_ISUPPORTS and a
class with a constructor (and if they don't want to take up space, they could
use one of the two existing constructors created by this bug and bug 166147 --
one is used always and the other is #ifdef DEBUG).

(Am I the only one who finds NS_INIT_ISUPPORTS() somewhat ugly in a C++ world,
where member initializers are preferred to assigments in the constructor?  I
also usually forget it when I'm implementing nsISupports.)

Comment 5

[Doug Turner (:dougt)]

if there is another way, great.  After thinking about this for a bit, the DECL
macro could probably do everything we need.  Before you land this, please post
an announcement to the xpcom ng.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

news://news.mozilla.org:119/[e-mail]

Comment 7

[Alec Flett]

Comment on attachment 102723 [details] [diff] [review]
patch

nice! sr=alecf

Comment 8

[Bradley Baetz (:bbaetz)]

GetThread should probably be a const function.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-11-06 05:09 PDT, with bbaetz's comment addressed
by adding |const|.

I filed bug 178643 on eventually removing the uses of NS_INIT_ISUPPORTS from the
tree.

Comment 10

[jag (Peter Annema)]

Yay!

Comment 11

[timeless]

*** Bug 172845 has been marked as a duplicate of this bug. ***