1742320 - "Restart to Update Nightly" button is dark and unreadable while it has the keyboard focus

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[skierpage]

Attachment: Look at the [Restart to Update Nightly] button

The last two times I updated Firefox Nightly, the [Restart to Update Nightly] button in its "About Firefox Nightly" dialog is dark as if its fill color isn't being painted and its text is almost unreadable until I click on some other window at which point it appears normally.

The rendering glitch persists as I change focus between windows, but eventually stops happening. But if I dismiss the About dialog and bring it back with Help > About Nightly, the restart button appears dark and unreadable again.

This is with 96.0a1 (2021-11-20) (64-bit), on KDE Fedora spin, forcing Wayland with MOZ_ENABLE_WAYLAND=1 and force-enabling WebRender.

KDE's About This System reports:
Operating System: Fedora Linux 35
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.14.18-300.fc35.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i5-6300U CPU @ 2.40GHz
Memory: 7.6 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 520

I'll attach about:support.

Comment 1

[skierpage]

Attachment: Firefox About: Support output

Comment 2

[Andrei Purice]

Hey skierpage,
Could you test this issue on the nightly build as well? Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .

Comment 3

[skierpage]

(In reply to skierpage from comment #0)

This is with 96.0a1 (2021-11-20) (64-bit), on KDE Fedora spin, forcing Wayland with MOZ_ENABLE_WAYLAND=1 and force-enabling WebRender.
I mis-spoke, I update Nighly every day with a dummy profile that does not have many about:config changes (and then I restart with my normal profile). So the glitch happens running Wayland with default webrender settings.

(In reply to Andrei Purice from comment #2)

Could you test this issue on the nightly build as well? Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .
Also a fresh new profile could help.
I created a new profile, started yesterday's Nightly with that, and the "Restart to Update Nightly" rendering glitch still happened. I also tried with a brand-new download in a temp directory, and used the X11 rendering under Wayland (I unset MOZ_ENABLE_WAYLAND), and I'm pretty sure that still had the glitch, which is surprising.

Comment 4

[skierpage]

It's still happening. I think it's a keyboard focus issue. When the "Restart to Update Nightly" button appears, it has the focus (good) but its dark styling is unreadable against the dark colorscheme of the About Nightly dialog until it loses focus -- by changing the active window or just pressing [Tab] to move to another element. At that point the unfocused button has very different, readable styling. If you're having trouble reproducing, I don't know if Firefox for Linux is affected by me running as a Gnome-ish app under KDE using the Breeze theme.

I think this is the updateButton in aboutDialog.xhtml and browser/base/content/aboutDialog.css styles it but there's no CSS about focus there. I tried to turn on browser chrome debugging but the MDN instructions don't work for me.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Emilio, do you have an idea about what may be triggering this issue (or point us to someone that can take a look into it)?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I can reproduce this using the Breeze theme, this is somewhat unfortunate because Breeze's "focus" state is just a semi-transparent background. So if you have a button on a dark background like in the nightly update dialog then it loses contrast.

Let me try to come up with a fix...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1742320 - Use dark form controls on about dialog. r=#desktop-theme-reviewers

Some GTK light themes assume light backgrounds in some situations.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/babe6e5f9ba8
Use dark form controls on about dialog. r=desktop-theme-reviewers,dao

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/babe6e5f9ba8

Comment 10

[Ardelean Oana, Desktop QA [:oardelean]]

I tried to reproduce this on Wayland on Ubuntu 20.04 using the Breeze theme, with no success. Emilio, would you be so kind as to confirm the fix on the latest Beta/Nightly?
Thank you.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Checked both beta and Nightly, they work as expected.

Comment 12

[Ardelean Oana, Desktop QA [:oardelean]]

Thank you so much for verifying this! Based on your comment, I shall remove the qa-verify and update the tracking flags accordingly.